You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/07/05 06:17:22 UTC
Review Request 67830: Moved `executor::Call` validation to common
validation library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67830/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-9051
https://issues.apache.org/jira/browse/MESOS-9051
Repository: mesos
Description
-------
`executor::Call` validation is used by both the agent and the
executor driver, so move it to the common validation library.
Diffs
-----
src/common/validation.hpp fa7f4a7164fda0f6af98c60a27e944146a231ee7
src/common/validation.cpp f89b0ca886ef910d01cc0dba6e10505dc5e6ff6f
src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17
src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43
src/slave/validation.cpp 3e333a7b308ec9c42541036f52b48b4ad74f5b88
Diff: https://reviews.apache.org/r/67830/diff/1/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 67830: Moved `executor::Call` validation to common
validation library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67830/#review205735
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67830']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67830
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67830/logs/mesos-tests-stdout.log):
```
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (797 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (602 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1224 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (801 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (904 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (600 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5160 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4950 ms)
[----------] 24 tests from DockerContainerizerTest (91671 ms total)
[----------] 1 test from HungDockerTest
[ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000061F0FBDC0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000061F0FC020.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000001C3EEC7E070.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000001C3EF385088.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000001C3F047C4D0.
ERROR: 5 leaked mock objects found at program exit.
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67830/logs/mesos-tests-stderr.log):
```
I0705 07:14:33.270709 10704 authenticatee.cpp:299] Authentication success
I0705 07:14:33.270709 10940 master.cpp:9802] Successfully authenticated principal 'test-principal' at scheduler-95410873-6ffa-4c2f-81e9-3bad7ac58ad9@192.10.1.6:64891
I0705 07:14:33.270709 13468 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:64891
I0705 07:14:33.271716 12772 master.cpp:2927] Received SUBSCRIBE call for framework 'default' at scheduler-95410873-6ffa-4c2f-81e9-3bad7ac58ad9@192.10.1.6:64891
I0705 07:14:33.272716 12772 master.cpp:2234] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }'
I0705 07:14:33.272716 12936 master.cpp:3008] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0705 07:14:33.273715 12936 master.cpp:9993] Adding framework 0355c3cb-80d6-47f7-a0f1-bb48f80bf740-0000 (default) at scheduler-95410873-6ffa-4c2f-81e9-3bad7ac58ad9@192.10.1.6:64891 with roles { } suppressed
I0705 07:14:33.274713 10940 sched.cpp:749] Framework registered with 0355c3cb-80d6-47f7-a0f1-bb48f80bf740-0000
I0705 07:14:33.275730 13144 hierarchical.cpp:299] Added framework 0355c3cb-80d6-47f7-a0f1-bb48f80bf740-0000
E0705 07:14:33.370712 10704 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command,
operable program or batch file.
'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\mrX7cr\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On July 5, 2018, 2:17 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67830/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 2:17 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9051
> https://issues.apache.org/jira/browse/MESOS-9051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `executor::Call` validation is used by both the agent and the
> executor driver, so move it to the common validation library.
>
>
> Diffs
> -----
>
> src/common/validation.hpp fa7f4a7164fda0f6af98c60a27e944146a231ee7
> src/common/validation.cpp f89b0ca886ef910d01cc0dba6e10505dc5e6ff6f
> src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43
> src/slave/validation.cpp 3e333a7b308ec9c42541036f52b48b4ad74f5b88
>
>
> Diff: https://reviews.apache.org/r/67830/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67830: Moved `executor::Call` validation to common
validation library.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67830/#review205788
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 5, 2018, 6:17 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67830/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 6:17 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9051
> https://issues.apache.org/jira/browse/MESOS-9051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `executor::Call` validation is used by both the agent and the
> executor driver, so move it to the common validation library.
>
>
> Diffs
> -----
>
> src/common/validation.hpp fa7f4a7164fda0f6af98c60a27e944146a231ee7
> src/common/validation.cpp f89b0ca886ef910d01cc0dba6e10505dc5e6ff6f
> src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43
> src/slave/validation.cpp 3e333a7b308ec9c42541036f52b48b4ad74f5b88
>
>
> Diff: https://reviews.apache.org/r/67830/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67830: Moved `executor::Call` validation to common
validation library.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67830/#review205780
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67830]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 5, 2018, 2:17 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67830/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 2:17 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9051
> https://issues.apache.org/jira/browse/MESOS-9051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `executor::Call` validation is used by both the agent and the
> executor driver, so move it to the common validation library.
>
>
> Diffs
> -----
>
> src/common/validation.hpp fa7f4a7164fda0f6af98c60a27e944146a231ee7
> src/common/validation.cpp f89b0ca886ef910d01cc0dba6e10505dc5e6ff6f
> src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43
> src/slave/validation.cpp 3e333a7b308ec9c42541036f52b48b4ad74f5b88
>
>
> Diff: https://reviews.apache.org/r/67830/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>