You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/10 14:27:13 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2754: Removing delay after launch Project action terminates.
sdedic opened a new pull request #2754:
URL: https://github.com/apache/netbeans/pull/2754
There is a delay between a message is sent to a LSP client that a project Run/Debug action termianted. I've checked the project layer, and it seems that Out/Err streams are closed / flushed before the callback is called. Also Maven implementation seems to finish the output gathering task before declaring the execution complete and so seems Gradle.
So that would allow for a "strawman" fix - just remove the delay. Please review - anyone who remembers why the delay was introduced in the original LSP client implementation. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2754: Removing delay after launch Project action terminates.
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2754:
URL: https://github.com/apache/netbeans/pull/2754#issuecomment-777102667
I'll need to test this change on the delivery branch with the applied PR to verify that this is fine. I'll do that ASAP. But with this, also please remove the `waitForDebuggeeConsole` variable altogether as it's presence makes no sense any more. And please wait for the delivery branch to be merged as this will cause conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2754: Removing delay after launch Project action terminates.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2754:
URL: https://github.com/apache/netbeans/pull/2754#issuecomment-777317069
Is this targeted for 12.3 or 12.4? If 12.3 and merging to delivery, feel free to merge #2725 before us if you need to rebase on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2754: Removing delay after launch Project action terminates.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2754:
URL: https://github.com/apache/netbeans/pull/2754#issuecomment-777309228
OK, I'll wait for the other PR to merge, then I'll rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2754: Removing delay after launch Project action terminates.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2754:
URL: https://github.com/apache/netbeans/pull/2754#issuecomment-777455772
Rebased on & retargetted to `delivery` branch. Cleaned up `waitForDebuggeeConsole`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #2754: Removing delay after launch Project action terminates.
Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2754:
URL: https://github.com/apache/netbeans/pull/2754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists