You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by sp...@apache.org on 2018/03/14 23:23:40 UTC
ranger git commit: Revert "RANGER-2006: Fix problems detected by
static code analysis in ranger usersync for ldap sync source"
Repository: ranger
Updated Branches:
refs/heads/master ad426c24c -> 2aaa012dc
Revert "RANGER-2006: Fix problems detected by static code analysis in ranger usersync for ldap sync source"
This reverts commit a9fbbcafa75b48ccfac28544c624bdef7b6ae081.
Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/2aaa012d
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/2aaa012d
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/2aaa012d
Branch: refs/heads/master
Commit: 2aaa012dcf74dfd3952aabcc5c58681ab5d77054
Parents: ad426c2
Author: Sailaja Polavarapu <sp...@hortonworks.com>
Authored: Wed Mar 14 16:23:05 2018 -0700
Committer: Sailaja Polavarapu <sp...@hortonworks.com>
Committed: Wed Mar 14 16:23:05 2018 -0700
----------------------------------------------------------------------
.../process/LdapDeltaUserGroupBuilder.java | 2 +-
.../process/LdapUserGroupBuilder.java | 3 ++-
.../config/UserGroupSyncConfig.java | 27 --------------------
3 files changed, 3 insertions(+), 29 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ranger/blob/2aaa012d/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
----------------------------------------------------------------------
diff --git a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
index 3cf0240..7d85f33 100644
--- a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
+++ b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
@@ -941,7 +941,7 @@ public class LdapDeltaUserGroupBuilder extends AbstractUserGroupSource {
.append(groupDN).append(")");
}
filter.append("))");
- groupFilter += config.escapeSearchFilter(filter.toString());
+ groupFilter += filter;
LOG.info("extendedAllGroupsSearchFilter = " + groupFilter);
for (int ou=0; ou<groupSearchBase.length; ou++) {
http://git-wip-us.apache.org/repos/asf/ranger/blob/2aaa012d/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
----------------------------------------------------------------------
diff --git a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
index ae5b1ab..85cba3c 100644
--- a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
+++ b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
@@ -289,6 +289,7 @@ public class LdapUserGroupBuilder extends AbstractUserGroupSource {
+ ", ldapReferral: " + ldapReferral
);
}
+
}
private void closeLdapContext() throws Throwable {
@@ -839,7 +840,7 @@ public class LdapUserGroupBuilder extends AbstractUserGroupSource {
.append(groupDN).append(")");
}
filter.append("))");
- groupFilter += config.escapeSearchFilter(filter.toString());
+ groupFilter += filter;
LOG.debug("extendedAllGroupsSearchFilter = " + groupFilter);
for (String ou : groupSearchBase) {
http://git-wip-us.apache.org/repos/asf/ranger/blob/2aaa012d/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
----------------------------------------------------------------------
diff --git a/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java b/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
index ed07696..45eeb1b 100644
--- a/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
+++ b/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
@@ -960,33 +960,6 @@ public class UserGroupSyncConfig {
return deltaSyncEnabled;
}
- public String escapeSearchFilter(String searchFilter) {
- StringBuilder sb = new StringBuilder();
- for (int i = 0; i < searchFilter.length(); i++) {
- char ch = searchFilter.charAt(i);
- switch (ch) {
- case '\\':
- sb.append("\\5c");
- break;
- case '*':
- sb.append("\\2a");
- break;
- case '(':
- sb.append("\\28");
- break;
- case ')':
- sb.append("\\29");
- break;
- case '\u0000':
- sb.append("\\00");
- break;
- default:
- sb.append(ch);
- }
- }
- return sb.toString();
- }
-
/* Used only for unit testing */
public void setUserSearchFilter(String filter) {
prop.setProperty(LGSYNC_USER_SEARCH_FILTER, filter);