You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/23 04:18:39 UTC
[GitHub] [flink] lirui-apache opened a new pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
lirui-apache opened a new pull request #16936:
URL: https://github.com/apache/flink/pull/16936
…ting data when source is empty
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Make sure existing data is removed for `INSERT OVERWRITE` when source is empty
## Brief change log
- Remove the checkpoint logic in `FileSystemOutputFormat`, because it's only used in batch mode and currently the CP ID is always 0
- Refactor `FileSystemCommitter` and related tests for the above change
- Add a test case to verify
## Verifying this change
Added test case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16936:
URL: https://github.com/apache/flink/pull/16936#issuecomment-903431132
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a5d7f470383084bf1a30c81d89acc214ecb2bb74 (Mon Aug 23 04:20:50 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #16936:
URL: https://github.com/apache/flink/pull/16936#discussion_r698470965
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java
##########
@@ -73,6 +73,50 @@ public static void setup() {
@ClassRule public static TemporaryFolder tempFolder = new TemporaryFolder();
+ @Test
+ public void testOverwriteWithEmptySource() throws Exception {
+ TableEnvironment tableEnv = getTableEnvWithHiveCatalog();
+ tableEnv.executeSql("create database db1");
+ try {
+ tableEnv.useDatabase("db1");
+ tableEnv.executeSql("create table src (x int,p int)");
+ // non-partitioned table
+ tableEnv.executeSql("create table dest (x int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "dest")
+ .addRow(new Object[] {1})
+ .addRow(new Object[] {2})
+ .commit();
+ tableEnv.executeSql("insert overwrite table dest select x from src").await();
+ List<Row> results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from dest").collect());
+ assertEquals(0, results.size());
+ // dynamic partitioned table
+ tableEnv.executeSql("create table destp (x int) partitioned by (p int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {1})
+ .commit("p=1");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {2})
+ .commit("p=2");
+ tableEnv.executeSql("insert overwrite table destp partition (p) select * from src")
+ .await();
+ results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from destp order by x").collect());
+ assertEquals("[+I[1, 1], +I[2, 2]]", results.toString());
+ // static partitioned table
+ tableEnv.executeSql("insert overwrite table destp partition(p=1) select x from src")
Review comment:
Yes this is the expected behavior which is the same as hive. It's open to discussion whether flink should follow hive on this. This test is to make sure we'll be alerted if we change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16936:
URL: https://github.com/apache/flink/pull/16936#issuecomment-903439543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d7f470383084bf1a30c81d89acc214ecb2bb74",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22631",
"triggerID" : "a5d7f470383084bf1a30c81d89acc214ecb2bb74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d7f470383084bf1a30c81d89acc214ecb2bb74 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache closed pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
lirui-apache closed pull request #16936:
URL: https://github.com/apache/flink/pull/16936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #16936:
URL: https://github.com/apache/flink/pull/16936#discussion_r698470965
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java
##########
@@ -73,6 +73,50 @@ public static void setup() {
@ClassRule public static TemporaryFolder tempFolder = new TemporaryFolder();
+ @Test
+ public void testOverwriteWithEmptySource() throws Exception {
+ TableEnvironment tableEnv = getTableEnvWithHiveCatalog();
+ tableEnv.executeSql("create database db1");
+ try {
+ tableEnv.useDatabase("db1");
+ tableEnv.executeSql("create table src (x int,p int)");
+ // non-partitioned table
+ tableEnv.executeSql("create table dest (x int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "dest")
+ .addRow(new Object[] {1})
+ .addRow(new Object[] {2})
+ .commit();
+ tableEnv.executeSql("insert overwrite table dest select x from src").await();
+ List<Row> results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from dest").collect());
+ assertEquals(0, results.size());
+ // dynamic partitioned table
+ tableEnv.executeSql("create table destp (x int) partitioned by (p int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {1})
+ .commit("p=1");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {2})
+ .commit("p=2");
+ tableEnv.executeSql("insert overwrite table destp partition (p) select * from src")
+ .await();
+ results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from destp order by x").collect());
+ assertEquals("[+I[1, 1], +I[2, 2]]", results.toString());
+ // static partitioned table
+ tableEnv.executeSql("insert overwrite table destp partition(p=1) select x from src")
Review comment:
Yes this is the expected behavior which is the same as hive. It's open to discussion whether flink should follow hive on this. This test is to make sure we'll be alerted if we change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16936:
URL: https://github.com/apache/flink/pull/16936#discussion_r697330638
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java
##########
@@ -73,6 +73,50 @@ public static void setup() {
@ClassRule public static TemporaryFolder tempFolder = new TemporaryFolder();
+ @Test
+ public void testOverwriteWithEmptySource() throws Exception {
+ TableEnvironment tableEnv = getTableEnvWithHiveCatalog();
+ tableEnv.executeSql("create database db1");
+ try {
+ tableEnv.useDatabase("db1");
+ tableEnv.executeSql("create table src (x int,p int)");
+ // non-partitioned table
+ tableEnv.executeSql("create table dest (x int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "dest")
+ .addRow(new Object[] {1})
+ .addRow(new Object[] {2})
+ .commit();
+ tableEnv.executeSql("insert overwrite table dest select x from src").await();
+ List<Row> results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from dest").collect());
+ assertEquals(0, results.size());
+ // dynamic partitioned table
+ tableEnv.executeSql("create table destp (x int) partitioned by (p int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {1})
+ .commit("p=1");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {2})
+ .commit("p=2");
+ tableEnv.executeSql("insert overwrite table destp partition (p) select * from src")
+ .await();
+ results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from destp order by x").collect());
+ assertEquals("[+I[1, 1], +I[2, 2]]", results.toString());
+ // static partitioned table
+ tableEnv.executeSql("insert overwrite table destp partition(p=1) select x from src")
Review comment:
when insert overwrite paritioned table with specific partition eg. p = 1, it won't clear the data for the partition.
Is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache closed pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
lirui-apache closed pull request #16936:
URL: https://github.com/apache/flink/pull/16936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16936:
URL: https://github.com/apache/flink/pull/16936#issuecomment-903439543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d7f470383084bf1a30c81d89acc214ecb2bb74",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22631",
"triggerID" : "a5d7f470383084bf1a30c81d89acc214ecb2bb74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d7f470383084bf1a30c81d89acc214ecb2bb74 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16936:
URL: https://github.com/apache/flink/pull/16936#issuecomment-903439543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d7f470383084bf1a30c81d89acc214ecb2bb74",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5d7f470383084bf1a30c81d89acc214ecb2bb74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d7f470383084bf1a30c81d89acc214ecb2bb74 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16936:
URL: https://github.com/apache/flink/pull/16936#discussion_r697330638
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java
##########
@@ -73,6 +73,50 @@ public static void setup() {
@ClassRule public static TemporaryFolder tempFolder = new TemporaryFolder();
+ @Test
+ public void testOverwriteWithEmptySource() throws Exception {
+ TableEnvironment tableEnv = getTableEnvWithHiveCatalog();
+ tableEnv.executeSql("create database db1");
+ try {
+ tableEnv.useDatabase("db1");
+ tableEnv.executeSql("create table src (x int,p int)");
+ // non-partitioned table
+ tableEnv.executeSql("create table dest (x int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "dest")
+ .addRow(new Object[] {1})
+ .addRow(new Object[] {2})
+ .commit();
+ tableEnv.executeSql("insert overwrite table dest select x from src").await();
+ List<Row> results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from dest").collect());
+ assertEquals(0, results.size());
+ // dynamic partitioned table
+ tableEnv.executeSql("create table destp (x int) partitioned by (p int)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {1})
+ .commit("p=1");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "destp")
+ .addRow(new Object[] {2})
+ .commit("p=2");
+ tableEnv.executeSql("insert overwrite table destp partition (p) select * from src")
+ .await();
+ results =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select * from destp order by x").collect());
+ assertEquals("[+I[1, 1], +I[2, 2]]", results.toString());
+ // static partitioned table
+ tableEnv.executeSql("insert overwrite table destp partition(p=1) select x from src")
Review comment:
when insert overwrite paritioned table with specific partition eg. p = 1, it won't clear the data for the partition.
Is it expected?
But it seems no way to know which partition to be insert overwrite when there is no source data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org