You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "xhaktm00 (via GitHub)" <gi...@apache.org> on 2026/08/02 05:16:07 UTC
[PR] [ZEPPELIN-6556] Personalized mode leaks a non-owner's paragraph edits into the shared master paragraph [zeppelin]
xhaktm00 opened a new pull request, #5360:
URL: https://github.com/apache/zeppelin/pull/5360
…to ensure master paragraph integrity
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
*Please leave your type of PR only*
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update?
* Is there breaking changes for older versions?
* Does this needs documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6556] Personalized mode leaks a non-owner's paragraph edits into the shared master paragraph [zeppelin]
Posted by "xhaktm00 (via GitHub)" <gi...@apache.org>.
xhaktm00 commented on PR #5360:
URL: https://github.com/apache/zeppelin/pull/5360#issuecomment-5199857401
@tbonelee Thank you for the careful review. I've updated the manual verification steps to use `%md`, since `ShellInterpreter` returns `FormType.NATIVE` as you noted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6556] Personalized mode leaks a non-owner's paragraph edits into the shared master paragraph [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5360:
URL: https://github.com/apache/zeppelin/pull/5360#issuecomment-5194571666
LGTM. Verified on a running instance with Shiro auth: a non-owner's dynamic form change no longer touches the master paragraph, while their personal copy picks it up.
Nit on the manual verification steps: `%sh echo "hello, ${name=original}"` renders no dynamic form, since `ShellInterpreter` returns `FormType.NATIVE`. Use `%md` (`FormType.SIMPLE`) or `%sh(form=simple)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6556] Personalized mode leaks a non-owner's paragraph edits into the shared master paragraph [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5360:
URL: https://github.com/apache/zeppelin/pull/5360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6556] Personalized mode leaks a non-owner's paragraph edits into the shared master paragraph [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5360:
URL: https://github.com/apache/zeppelin/pull/5360#issuecomment-5194546193
I think there are two separate concerns mixed in here: fixing the leak itself, and deciding what the permission policy for personalized mode should be.
If personalized mode is meant to give each user their own view of the note, then arguably even the note owner should not affect the master paragraph while the mode is on. The earlier commit (apache/zeppelin@ac76546) looks closer to that.
One thing worth checking before settling on the owner-based gate is the `testGraphAction` failure that motivated it. In the original test (ZEPPELIN-2661) the owner set the chart type *before* turning personalized mode on, so nothing was written to the master paragraph while the mode was active. That order was flipped in ZEPPELIN-4361 ("Fix broken tests"), and the test now sets the chart type *after* the mode is on and asserts that a new user inherits it. So the assertion the earlier commit broke may not be describing the originally intended behavior.
@jongyoul you worked on the original implementation, so you may have the context here. Was the intent that the master paragraph stays frozen while personalized mode is on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6556] Personalized mode leaks a non-owner's paragraph edits into the shared master paragraph [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5360:
URL: https://github.com/apache/zeppelin/pull/5360#issuecomment-5242028709
Merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org