[GitHub] [flink] hequn8128 commented on a change in pull request #13117: [FLINK-18863][python] Support read_text_file() and print() interface …

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #13117:
URL: https://github.com/apache/flink/pull/13117#discussion_r468472919



##########
File path: flink-python/pyflink/datastream/stream_execution_environment.py
##########
@@ -465,6 +465,19 @@ def add_source(self, source_func: SourceFunction, source_name: str = 'Custom Sou
                                                                        j_type_info)
         return DataStream(j_data_stream=j_data_stream)
 
+    def read_text_file(self, file_path: str, charset_name: str = "UTF-8") -> DataStream:

Review comment:
       Adds note that this API is not fault-tolerant and only used in test scenarios.  

##########
File path: flink-python/pyflink/datastream/data_stream.py
##########
@@ -483,7 +518,17 @@ def reduce(self, func: Union[Callable, ReduceFunction]) -> 'DataStream':
             j_python_data_stream_scalar_function_operator
         ))
 
-    def _values(self):
+    def key_by(self, key_selector: Union[Callable, KeySelector],

Review comment:
       The two methods are not supposed to be added in this PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org