You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Sijie Guo (Commented) (JIRA)" <ji...@apache.org> on 2012/02/07 04:19:07 UTC

[jira] [Commented] (BOOKKEEPER-161) PerChannelBookieClient tries to reuse HashedWheelTimer, throws Exception

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202042#comment-13202042 ] 

Sijie Guo commented on BOOKKEEPER-161:
--------------------------------------

it looks good to me. +1
                
> PerChannelBookieClient tries to reuse HashedWheelTimer, throws Exception
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-161
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-161
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-161.diff
>
>
> A hashedWheelTimer can only be stopped once, but in the current implementation, only one HashedWheelTimer is used per PerChannelBookieClient which can connect and disconnect many time. Currently stop the hashWheelTimer any time a channel is disconnected, but only create it once in the constructor. This causes exceptions to be thrown in the netty callback thread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira