You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devmadhuu (via GitHub)" <gi...@apache.org> on 2023/09/19 15:26:56 UTC
[GitHub] [ozone] devmadhuu opened a new pull request, #5323: HDDS-9276. Mark disabled tests using custom tag/category.
devmadhuu opened a new pull request, #5323:
URL: https://github.com/apache/ozone/pull/5323
## What changes were proposed in this pull request?
The goal of this PR is to replace these @Ignore and @Disabled annotations with conditional ones. Regular CI should still skip them, but we would like to include them in nightly or other scheduled runs.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9276
## How was this patch tested?
This patch is tested with existing CI workflow run of unit and integration tests where tests annotated with "Unhealthy" annotation would not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] devmadhuu commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1332455475
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfacesWithFSO.java:
##########
@@ -43,35 +45,35 @@ public TestOzoneFileInterfacesWithFSO(boolean setDefaultFs,
@Override
@Test
- @Ignore("HDDS-2939")
+ @Category(UnhealthyTest.class) @Unhealthy("HDDS-2939")
public void testReplication() throws IOException {
// ignore as this is not relevant to PREFIX layout changes
Review Comment:
Ok @adoroszlai. I have better kept them ignored as earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1331670522
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfacesWithFSO.java:
##########
@@ -43,35 +45,35 @@ public TestOzoneFileInterfacesWithFSO(boolean setDefaultFs,
@Override
@Test
- @Ignore("HDDS-2939")
+ @Category(UnhealthyTest.class) @Unhealthy("HDDS-2939")
public void testReplication() throws IOException {
// ignore as this is not relevant to PREFIX layout changes
Review Comment:
I think we might want to keep these empty "not relevant" test cases ignored. There is no harm in running them, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] devmadhuu commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1333874836
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemWithFSO.java:
##########
@@ -85,6 +85,12 @@ public TestOzoneFileSystemWithFSO(boolean setDefaultFs,
@Override
public void cleanup() {
super.cleanup();
+ try {
+ deleteRootDir();
+ } catch (IOException e) {
+ LOG.info("Failed to cleanup DB tables.", e);
+ fail("Failed to cleanup DB tables." + e.getMessage());
+ }
Review Comment:
> This recently added part seems unrelated.
Ok, its handled. I think it came while resolving conflict. Checked carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1331436401
##########
hadoop-ozone/dev-support/checks/unit.sh:
##########
@@ -16,4 +16,4 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
CHECK=unit
-source "${DIR}/junit.sh" -pl \!:ozone-integration-test,\!:mini-chaos-tests -DexcludedGroups=native "$@"
+source "${DIR}/junit.sh" -pl \!:ozone-integration-test,\!:mini-chaos-tests -DexcludedGroups=native | unhealthy "$@"
Review Comment:
Need to quote the parameter value, as `|` is a special symbol for the shell, too. And the category is needed for JUnit4.
```suggestion
source "${DIR}/junit.sh" -pl \!:ozone-integration-test,\!:mini-chaos-tests -DexcludedGroups="native | unhealthy | org.apache.ozone.test.UnhealthyTest" "$@"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] devmadhuu commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1331626938
##########
hadoop-ozone/dev-support/checks/unit.sh:
##########
@@ -16,4 +16,4 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
CHECK=unit
-source "${DIR}/junit.sh" -pl \!:ozone-integration-test,\!:mini-chaos-tests -DexcludedGroups=native "$@"
+source "${DIR}/junit.sh" -pl \!:ozone-integration-test,\!:mini-chaos-tests -DexcludedGroups=native | unhealthy "$@"
Review Comment:
Thanks @adoroszlai for proactively reviewing it. Handled the above issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1332996431
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfacesWithFSO.java:
##########
@@ -43,35 +45,35 @@ public TestOzoneFileInterfacesWithFSO(boolean setDefaultFs,
@Override
@Test
- @Ignore("HDDS-2939")
+ @Category(UnhealthyTest.class) @Unhealthy("HDDS-2939")
public void testReplication() throws IOException {
// ignore as this is not relevant to PREFIX layout changes
Review Comment:
Thanks, but the same applies to two other FSO test classes, too:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemWithFSO.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5323:
URL: https://github.com/apache/ozone/pull/5323#discussion_r1333279868
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemWithFSO.java:
##########
@@ -85,6 +85,12 @@ public TestOzoneFileSystemWithFSO(boolean setDefaultFs,
@Override
public void cleanup() {
super.cleanup();
+ try {
+ deleteRootDir();
+ } catch (IOException e) {
+ LOG.info("Failed to cleanup DB tables.", e);
+ fail("Failed to cleanup DB tables." + e.getMessage());
+ }
Review Comment:
This recently added part seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #5323: HDDS-9276. Mark disabled tests using custom tag/category.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5323:
URL: https://github.com/apache/ozone/pull/5323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org