You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/08/24 10:35:11 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
MaxGekk opened a new pull request, #42655:
URL: https://github.com/apache/spark/pull/42655
### What changes were proposed in this pull request?
In the PR, I propose to make the `array_insert` function 1-based for negative indexes. So, the maximum index is -1 should point out to the last element, and the function should insert new element at the end of the given array for the index -1.
The old behaviour can be restored via the SQL config `spark.sql.legacy.negativeIndexInArrayInsert`.
This is a backport of https://github.com/apache/spark/pull/42564
### Why are the changes needed?
1. To match the behaviour of functions such as `substr()` and `element_at()`.
```sql
spark-sql (default)> select element_at(array('a', 'b'), -1), substr('ab', -1);
b b
```
2. To fix an inconsistency in `array_insert` in which positive indexes are 1-based, but negative indexes are 0-based.
### Does this PR introduce _any_ user-facing change?
Yes.
Before:
```sql
spark-sql (default)> select array_insert(array('a', 'b'), -1, 'c');
["a","c","b"]
```
After:
```sql
spark-sql (default)> select array_insert(array('a', 'b'), -1, 'c');
["a","b","c"]
```
### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "test:testOnly *CollectionExpressionsSuite"
$ build/sbt "test:testOnly *DataFrameFunctionsSuite"
$ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
```
Authored-by: Max Gekk <ma...@gmail.com>
(cherry picked from commit ce50a563d311ccfe36d1fcc4f0743e4e4d7d8116)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42655:
URL: https://github.com/apache/spark/pull/42655#issuecomment-1692081839
Merged to branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42655:
URL: https://github.com/apache/spark/pull/42655#discussion_r1304228403
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4185,6 +4185,18 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_NEGATIVE_INDEX_IN_ARRAY_INSERT =
+ buildConf("spark.sql.legacy.negativeIndexInArrayInsert")
+ .internal()
+ .doc("When set to true, restores the legacy behavior of `array_insert` for " +
+ "negative indexes - 0-based: the function inserts new element before the last one " +
+ "for the index -1. For example, `array_insert(['a', 'b'], -1, 'x')` returns " +
+ "`['a', 'x', 'b']`. When set to false, the -1 index points out to the last element, " +
+ "and the given example produces `['a', 'b', 'x']`.")
+ .version("3.5.0")
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #42655:
URL: https://github.com/apache/spark/pull/42655#discussion_r1304347466
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4185,6 +4185,18 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_NEGATIVE_INDEX_IN_ARRAY_INSERT =
+ buildConf("spark.sql.legacy.negativeIndexInArrayInsert")
+ .internal()
+ .doc("When set to true, restores the legacy behavior of `array_insert` for " +
+ "negative indexes - 0-based: the function inserts new element before the last one " +
+ "for the index -1. For example, `array_insert(['a', 'b'], -1, 'x')` returns " +
+ "`['a', 'x', 'b']`. When set to false, the -1 index points out to the last element, " +
+ "and the given example produces `['a', 'b', 'x']`.")
+ .version("3.5.0")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on a diff in pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on code in PR #42655:
URL: https://github.com/apache/spark/pull/42655#discussion_r1304141918
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4185,6 +4185,18 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_NEGATIVE_INDEX_IN_ARRAY_INSERT =
+ buildConf("spark.sql.legacy.negativeIndexInArrayInsert")
+ .internal()
+ .doc("When set to true, restores the legacy behavior of `array_insert` for " +
+ "negative indexes - 0-based: the function inserts new element before the last one " +
+ "for the index -1. For example, `array_insert(['a', 'b'], -1, 'x')` returns " +
+ "`['a', 'x', 'b']`. When set to false, the -1 index points out to the last element, " +
+ "and the given example produces `['a', 'b', 'x']`.")
+ .version("3.5.0")
Review Comment:
Should this be `3.4.2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on a diff in pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on code in PR #42655:
URL: https://github.com/apache/spark/pull/42655#discussion_r1304141918
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4185,6 +4185,18 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_NEGATIVE_INDEX_IN_ARRAY_INSERT =
+ buildConf("spark.sql.legacy.negativeIndexInArrayInsert")
+ .internal()
+ .doc("When set to true, restores the legacy behavior of `array_insert` for " +
+ "negative indexes - 0-based: the function inserts new element before the last one " +
+ "for the index -1. For example, `array_insert(['a', 'b'], -1, 'x')` returns " +
+ "`['a', 'x', 'b']`. When set to false, the -1 index points out to the last element, " +
+ "and the given example produces `['a', 'b', 'x']`.")
+ .version("3.5.0")
Review Comment:
Shouldn't this be `3.4.2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42655: [SPARK-44840][SQL][3.4] Make `array_insert()` 1-based for negative indexes
URL: https://github.com/apache/spark/pull/42655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org