You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SzyWilliam (via GitHub)" <gi...@apache.org> on 2023/05/10 12:03:26 UTC

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #9797: [IOTDB-5852] Add some IoTConsensus and RatisConsensus properties

SzyWilliam commented on code in PR #9797:
URL: https://github.com/apache/iotdb/pull/9797#discussion_r1189805046


##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java:
##########
@@ -237,7 +239,9 @@ public class ConfigNodeConfig {
   private long configNodeSimpleConsensusLogSegmentSizeMax = 24 * 1024 * 1024L;
 
   /** RatisConsensus protocol, flow control window for ratis grpc log appender */
-  private long dataRegionRatisGrpcFlowControlWindow = 4 * 1024 * 1024L;
+  private long dataRegionRatisGrpcFlowControlWindow = 16 * 1024 * 1024L;

Review Comment:
   Why change the default value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org