You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/03 13:28:54 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #10829: Add acl_policy into GCSToS3Operator (#10804)

turbaszek commented on a change in pull request #10829:
URL: https://github.com/apache/airflow/pull/10829#discussion_r499148040



##########
File path: airflow/providers/amazon/aws/transfers/gcs_to_s3.py
##########
@@ -82,6 +82,9 @@ class GCSToS3Operator(BaseOperator):
         Service Account Token Creator IAM role to the directly preceding identity, with first
         account from the list granting this role to the originating account (templated).
     :type google_impersonation_chain: Union[str, Sequence[str]]
+    :param acl_policy: Optional The string to specify the canned ACL policy for the

Review comment:
       Should we renamed it to `s3_acl_policy` to make it more explicit? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org