You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by jo...@apache.org on 2010/02/03 20:23:14 UTC
svn commit: r906191 -
/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
Author: johnh
Date: Wed Feb 3 19:23:14 2010
New Revision: 906191
URL: http://svn.apache.org/viewvc?rev=906191&view=rev
Log:
Invalid header param is an INVALID_PARAMETER-class error, not an internal server exception, as it's the result of user input.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java?rev=906191&r1=906190&r2=906191&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java Wed Feb 3 19:23:14 2010
@@ -128,8 +128,8 @@
for (String header : headerList) {
String[] parts = StringUtils.splitPreserveAllTokens(header, '=');
if (parts.length != 2) {
- throw new GadgetException(GadgetException.Code.INTERNAL_SERVER_ERROR,
- "Malformed header specified,");
+ throw new GadgetException(GadgetException.Code.INVALID_PARAMETER,
+ "Malformed header param specified:" + header);
}
String headerName = Utf8UrlCoder.decode(parts[0]);
if (!HttpRequestHandler.BAD_HEADERS.contains(headerName.toUpperCase())) {