You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/09 07:05:20 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4182: [FIX-#4172][server-worker] kill task NPE
codecov-io edited a comment on pull request #4182:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4182#issuecomment-741515026
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=h1) Report
> Merging [#4182](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=desc) (84b2265) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/966600cc3710938337749588560329a31579a63f?el=desc) (966600c) will **decrease** coverage by `0.02%`.
> The diff coverage is `30.15%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4182 +/- ##
============================================
- Coverage 41.37% 41.34% -0.03%
Complexity 3115 3115
============================================
Files 467 467
Lines 22168 22186 +18
Branches 2720 2722 +2
============================================
+ Hits 9172 9173 +1
- Misses 12113 12129 +16
- Partials 883 884 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nscheduler/server/entity/TaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9UYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `96.36% <ø> (ø)` | `71.00 <0.00> (ø)` | |
| [...ler/server/worker/processor/TaskKillProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0tpbGxQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `4.66% <4.00%> (-0.18%)` | `2.00 <0.00> (ø)` | |
| [...che/impl/TaskExecutionContextCacheManagerImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9jYWNoZS9pbXBsL1Rhc2tFeGVjdXRpb25Db250ZXh0Q2FjaGVNYW5hZ2VySW1wbC5qYXZh) | `66.66% <50.00%> (-19.05%)` | `3.00 <1.00> (ø)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `69.11% <84.21%> (+1.90%)` | `7.00 <2.00> (+2.00)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.00% <0.00%> (-2.78%)` | `9.00% <0.00%> (-2.00%)` | |
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `60.97% <0.00%> (-2.44%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=footer). Last update [966600c...84b2265](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org