[GitHub] [zookeeper] anmolnar commented on a change in pull request #1171: ZOOKEEPER-2083 Remove deprecated class AuthFastLeaderElection

[GitBox <gi...@apache.org>]

anmolnar commented on a change in pull request #1171: ZOOKEEPER-2083 Remove deprecated class AuthFastLeaderElection
URL: https://github.com/apache/zookeeper/pull/1171#discussion_r363226436
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
 ##########
 @@ -1221,36 +1221,23 @@ protected Observer makeObserver(FileTxnSnapLog logFactory) throws IOException {
     }
 
     @SuppressWarnings("deprecation")
-    protected Election createElectionAlgorithm(int electionAlgorithm) {
 
 Review comment:
   I agree with @phunt . Let's keep this patch as simple as possible which would also make backporting easier. I would just blindly remove the option for AuthFastLeaderElection (and the class itself) making a note in documentation that it has been deprecated since 3.4.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services