You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/27 21:52:01 UTC
[GitHub] codecov-io commented on issue #3336: Add metric when querying
non-existing columns
codecov-io commented on issue #3336: Add metric when querying non-existing columns
URL: https://github.com/apache/incubator-pinot/pull/3336#issuecomment-442231005
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=h1) Report
> Merging [#3336](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8e2076f5ba8b1869b3f6016a295210ccb6213ee6?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `95.45%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3336 +/- ##
============================================
- Coverage 70.89% 70.81% -0.09%
Complexity 4 4
============================================
Files 997 997
Lines 45759 45774 +15
Branches 6135 6138 +3
============================================
- Hits 32442 32416 -26
- Misses 11183 11223 +40
- Partials 2134 2135 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inot/core/query/pruner/PartitionSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9QYXJ0aXRpb25TZWdtZW50UHJ1bmVyLmphdmE=) | `80% <0%> (-2.76%)` | `0 <0> (ø)` | |
| [.../pinot/core/query/pruner/SegmentPrunerService.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9TZWdtZW50UHJ1bmVyU2VydmljZS5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...com/linkedin/pinot/common/metrics/ServerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL1NlcnZlck1ldGVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...core/query/executor/ServerQueryExecutorV1Impl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L2V4ZWN1dG9yL1NlcnZlclF1ZXJ5RXhlY3V0b3JWMUltcGwuamF2YQ==) | `81.14% <100%> (+2.24%)` | `0 <0> (ø)` | :arrow_down: |
| [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L0VtcHR5QnJva2VyT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `81.81% <0%> (-10.91%)` | `0% <0%> (ø)` | |
| [...core/operator/blocks/IntermediateResultsBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2Jsb2Nrcy9JbnRlcm1lZGlhdGVSZXN1bHRzQmxvY2suamF2YQ==) | `74.16% <0%> (-10%)` | `0% <0%> (ø)` | |
| [...ore/query/scheduler/resources/ResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3NjaGVkdWxlci9yZXNvdXJjZXMvUmVzb3VyY2VNYW5hZ2VyLmphdmE=) | `87.09% <0%> (-9.68%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `87.27% <0%> (-5.46%)` | `0% <0%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=footer). Last update [8e2076f...b43988f](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org