You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/23 04:52:47 UTC
[GitHub] [flink] TsReaper opened a new pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
TsReaper opened a new pull request #12750:
URL: https://github.com/apache/flink/pull/12750
## What is the purpose of the change
Currently CollectResultIterator will only output results after a checkpoint in streaming mode. It will be strange for users who does not enable checkpointing to stuck forever when using the iterator without further notice.
As 1.11 is about to release, we shall at least throw an exception notifying the user to enable checkpointing. We'll support iterators with at least once semantics or exactly once semantics without fault tolerance in the future.
## Brief change log
- CollectResultIterator now throws exception if user does not enable checkpointing in streaming mode
## Verifying this change
This change is already covered by existing tests, such as `TableEnvironmentITCase`.
This change can also be verified by newly added tests in `TableEnvironmentTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12750:
URL: https://github.com/apache/flink/pull/12750#discussion_r444081509
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala
##########
@@ -71,9 +75,23 @@ class TableEnvironmentITCase(tableEnvName: String, isStreaming: Boolean) extends
tableEnvName match {
case "TableEnvironment" =>
tEnv = TableEnvironmentImpl.create(settings)
+ if (isStreaming) {
+ tEnv.getConfig.getConfiguration.set(
+ ExecutionCheckpointingOptions.CHECKPOINTING_MODE,
+ CheckpointingMode.EXACTLY_ONCE)
+ tEnv.getConfig.getConfiguration.set(
+ ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL,
+ Duration.ofMillis(CheckpointCoordinatorConfiguration.MINIMAL_CHECKPOINT_TIME)
+ )
+ }
case "StreamTableEnvironment" =>
- tEnv = StreamTableEnvironment.create(
- StreamExecutionEnvironment.getExecutionEnvironment, settings)
+ val execEnv = StreamExecutionEnvironment.getExecutionEnvironment
+ tEnv = StreamTableEnvironment.create(execEnv, settings)
+ if (isStreaming) {
Review comment:
also use `tEnv.getConfig.getConfiguration.set()` ? then we can move them into one place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TsReaper closed pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
TsReaper closed pull request #12750:
URL: https://github.com/apache/flink/pull/12750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-647920503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941",
"triggerID" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"triggerType" : "PUSH"
}, {
"hash" : "04b143b71fe1ac2e6be426fcf8ffda17d971aad2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04b143b71fe1ac2e6be426fcf8ffda17d971aad2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98bb13417ab3edb063aa38194f529403278a5ee3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941)
* 04b143b71fe1ac2e6be426fcf8ffda17d971aad2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-647920503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941",
"triggerID" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"triggerType" : "PUSH"
}, {
"hash" : "04b143b71fe1ac2e6be426fcf8ffda17d971aad2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04b143b71fe1ac2e6be426fcf8ffda17d971aad2",
"triggerType" : "PUSH"
}, {
"hash" : "1e10feac0e4967978bfbfc2337b6064706560183",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3949",
"triggerID" : "1e10feac0e4967978bfbfc2337b6064706560183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04b143b71fe1ac2e6be426fcf8ffda17d971aad2 UNKNOWN
* 1e10feac0e4967978bfbfc2337b6064706560183 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3949)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-647920503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941",
"triggerID" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98bb13417ab3edb063aa38194f529403278a5ee3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-647920503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941",
"triggerID" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"triggerType" : "PUSH"
}, {
"hash" : "04b143b71fe1ac2e6be426fcf8ffda17d971aad2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04b143b71fe1ac2e6be426fcf8ffda17d971aad2",
"triggerType" : "PUSH"
}, {
"hash" : "1e10feac0e4967978bfbfc2337b6064706560183",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e10feac0e4967978bfbfc2337b6064706560183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98bb13417ab3edb063aa38194f529403278a5ee3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3941)
* 04b143b71fe1ac2e6be426fcf8ffda17d971aad2 UNKNOWN
* 1e10feac0e4967978bfbfc2337b6064706560183 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-647907034
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 98bb13417ab3edb063aa38194f529403278a5ee3 (Tue Jun 23 04:55:41 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18413).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-647920503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98bb13417ab3edb063aa38194f529403278a5ee3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98bb13417ab3edb063aa38194f529403278a5ee3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TsReaper commented on pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode
Posted by GitBox <gi...@apache.org>.
TsReaper commented on pull request #12750:
URL: https://github.com/apache/flink/pull/12750#issuecomment-648089135
After the Azure testing I found that this "fix" will affect a large amount of test cases. Most streaming test cases do not enable checkpointing, but as they are bounded stream the results will be delivered once the job finishes. @twalthr also points out that this "fix" seems a bit hack at first glance, so I think we should not fix this at the last minute of 1.11 and leave these improvements to 1.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org