[GitHub] [solr] cpoerschke commented on a change in pull request #694: SOLR-16041: Prepare Smoketester to be able to run on local release folder in Jenkins

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #694:
URL: https://github.com/apache/solr/pull/694#discussion_r814999183



##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -115,7 +115,7 @@ def noJavaPackageClasses(desc, file):
   with zipfile.ZipFile(file) as z2:
     for name2 in z2.namelist():
       if name2.endswith('.class') and (name2.startswith('java/') or name2.startswith('javax/')):
-        raise RuntimeError('%s contains sheisty class "%s"' %  (desc, name2))
+        raise RuntimeError('%s contains sheisty class "%s"' % (desc, name2))

Review comment:
       ```suggestion
           raise RuntimeError('%s contains java or javax class "%s"' % (desc, name2))
   ```

##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1104,9 +1106,14 @@ def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, local_keys,
     print('  unshortened: %s' % newBaseURL)
     baseURL = newBaseURL
 
-  for text, subURL in getDirEntries(baseURL):
-    if text.lower().find('solr') != -1:
-      solrPath = subURL
+  if baseURL.endswith('distribution/build/release'):
+    # Used when buiding release locally in Jenkins

Review comment:
       ```suggestion
       # Used when building release locally in Jenkins
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org