You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 18:01:02 UTC
[GitHub] [beam] robinyqiu opened a new pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
robinyqiu opened a new pull request #12550:
URL: https://github.com/apache/beam/pull/12550
https://github.com/apache/beam/pull/12507 revealed a bug related to duplicate STRUCT field name. This PR fix it by following the same way that BigQuery handles unspecified or duplicate field name.
r: @apilloud
cc: @youngoli (2.24 release manager, this is a fix for a previous PR)
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on a change in pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on a change in pull request #12550:
URL: https://github.com/apache/beam/pull/12550#discussion_r469466085
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java
##########
@@ -180,12 +182,19 @@ private static RelDataType toCalciteStructType(
private static List<String> getFieldNameList(List<StructField> fields) {
ImmutableList.Builder<String> b = ImmutableList.builder();
+ Set<String> usedName = new HashSet<>();
for (int i = 0; i < fields.size(); i++) {
String name = fields.get(i).getName();
- if ("".equals(name)) {
- name = "$col" + i; // avoid empty field names because Beam does not allow duplicate names
+ // Follow the same way that BigQuery handles unspecified or duplicate field name
+ if ("".equals(name) || usedName.contains(name)) {
Review comment:
OK I got your point now. So I believe the condition should be `"".equals(name) || name.startsWith("_field_") || usedName.contains(name)`. This way we can avoid throwing the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on a change in pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
apilloud commented on a change in pull request #12550:
URL: https://github.com/apache/beam/pull/12550#discussion_r469461524
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java
##########
@@ -180,12 +182,19 @@ private static RelDataType toCalciteStructType(
private static List<String> getFieldNameList(List<StructField> fields) {
ImmutableList.Builder<String> b = ImmutableList.builder();
+ Set<String> usedName = new HashSet<>();
for (int i = 0; i < fields.size(); i++) {
String name = fields.get(i).getName();
- if ("".equals(name)) {
- name = "$col" + i; // avoid empty field names because Beam does not allow duplicate names
+ // Follow the same way that BigQuery handles unspecified or duplicate field name
+ if ("".equals(name) || usedName.contains(name)) {
Review comment:
This does not actually match the behavior of BigQuery. To match BigQuery you should remove the `HashSet` and instead replace anything starting with `_field_` with the correct index for that column.
(In BigQuery, this condition would be `"".equals(name) || name.startsWith("_field_")`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu merged pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu merged pull request #12550:
URL: https://github.com/apache/beam/pull/12550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on a change in pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on a change in pull request #12550:
URL: https://github.com/apache/beam/pull/12550#discussion_r469466085
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java
##########
@@ -180,12 +182,19 @@ private static RelDataType toCalciteStructType(
private static List<String> getFieldNameList(List<StructField> fields) {
ImmutableList.Builder<String> b = ImmutableList.builder();
+ Set<String> usedName = new HashSet<>();
for (int i = 0; i < fields.size(); i++) {
String name = fields.get(i).getName();
- if ("".equals(name)) {
- name = "$col" + i; // avoid empty field names because Beam does not allow duplicate names
+ // Follow the same way that BigQuery handles unspecified or duplicate field name
+ if ("".equals(name) || usedName.contains(name)) {
Review comment:
OK I got your point now. So I believe the condition should be `"".equals(name) || name.startsWith("_field_") || usedName.contains(name)`. This way we can avoid the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on pull request #12550:
URL: https://github.com/apache/beam/pull/12550#issuecomment-673033581
Tested internally. This fixes the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on a change in pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
apilloud commented on a change in pull request #12550:
URL: https://github.com/apache/beam/pull/12550#discussion_r469465254
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java
##########
@@ -180,12 +182,19 @@ private static RelDataType toCalciteStructType(
private static List<String> getFieldNameList(List<StructField> fields) {
ImmutableList.Builder<String> b = ImmutableList.builder();
+ Set<String> usedName = new HashSet<>();
for (int i = 0; i < fields.size(); i++) {
String name = fields.get(i).getName();
- if ("".equals(name)) {
- name = "$col" + i; // avoid empty field names because Beam does not allow duplicate names
+ // Follow the same way that BigQuery handles unspecified or duplicate field name
+ if ("".equals(name) || usedName.contains(name)) {
Review comment:
I run `SELECT STRUCT("abc" AS _field_22, 3 AS _field_23)` on BigQuery. The result is a row of 2 files whoes names are `f0_._field_1` and `f0_._field_2`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on pull request #12550:
URL: https://github.com/apache/beam/pull/12550#issuecomment-673047454
Thank you very much Andrew, for catching the problem and the quick review!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on a change in pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
apilloud commented on a change in pull request #12550:
URL: https://github.com/apache/beam/pull/12550#discussion_r469465254
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java
##########
@@ -180,12 +182,19 @@ private static RelDataType toCalciteStructType(
private static List<String> getFieldNameList(List<StructField> fields) {
ImmutableList.Builder<String> b = ImmutableList.builder();
+ Set<String> usedName = new HashSet<>();
for (int i = 0; i < fields.size(); i++) {
String name = fields.get(i).getName();
- if ("".equals(name)) {
- name = "$col" + i; // avoid empty field names because Beam does not allow duplicate names
+ // Follow the same way that BigQuery handles unspecified or duplicate field name
+ if ("".equals(name) || usedName.contains(name)) {
Review comment:
I run `SELECT STRUCT("abc" AS _field_22, 3 AS _field_23)` on BigQuery. The result is a row of 2 fields whose names are `f0_._field_1` and `f0_._field_2`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on a change in pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on a change in pull request #12550:
URL: https://github.com/apache/beam/pull/12550#discussion_r469463169
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java
##########
@@ -180,12 +182,19 @@ private static RelDataType toCalciteStructType(
private static List<String> getFieldNameList(List<StructField> fields) {
ImmutableList.Builder<String> b = ImmutableList.builder();
+ Set<String> usedName = new HashSet<>();
for (int i = 0; i < fields.size(); i++) {
String name = fields.get(i).getName();
- if ("".equals(name)) {
- name = "$col" + i; // avoid empty field names because Beam does not allow duplicate names
+ // Follow the same way that BigQuery handles unspecified or duplicate field name
+ if ("".equals(name) || usedName.contains(name)) {
Review comment:
I run `SELECT STRUCT("abc" as a, 3 as a)` on BigQuery. The result is a row of 2 fields whose names are `f0_.a` and `f0_._field_2`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on pull request #12550: Follow the same way that BigQuery handles unspecified or duplicate ZetaSQL STRUCT field name
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on pull request #12550:
URL: https://github.com/apache/beam/pull/12550#issuecomment-673032226
Run Spotless PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org