[jira] [Commented] (PIVOT-721) ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't have fill style

["Sandro Martini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428149#comment-13428149 ] 

Sandro Martini commented on PIVOT-721:
--------------------------------------

Just committed the first part of the fix, and two test cases, as usual under tests/ ... / Pivot721.java and related bxml files.
Note that up to now it seems that the image scaled down (second row, left image) is Ok, while the image scaled up (second row, right image) doesn't scale up with all available space inside the button ... so we have to look better to solve even this.

For now only in 2.0.x maintenance branch:
Committed revision 1369004.

                
> ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't have fill style
> -----------------------------------------------------------------------------------------
>
>                 Key: PIVOT-721
>                 URL: https://issues.apache.org/jira/browse/PIVOT-721
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: Bill van Melle
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.0.3
>
>
> ButtonDataRenderer has a setFillIcon method, which supposedly should allow the button's image to be scaled to fit the button.  However, it has no effect, because the renderer is a BoxPane with the default fill=false.
> Fix: In the ButtonDataRenderer constructor, add
>     getStyles().put("fill", true);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira