You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2008/01/24 13:37:34 UTC

[jira] Created: (JCR-1343) Replace xerces for serialization by JAXP

Replace xerces for serialization by JAXP
----------------------------------------

                 Key: JCR-1343
                 URL: https://issues.apache.org/jira/browse/JCR-1343
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-jcr-rmi
    Affects Versions: 1.4
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger
             Fix For: 1.5


The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584739#action_12584739 ] 

Felix Meschberger commented on JCR-1343:
----------------------------------------

Backported change of Rev. 616082 to 1.4 branch in Rev. 644020 for inclusion in the rmi 1.4.1 release.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584769#action_12584769 ] 

Felix Meschberger commented on JCR-1343:
----------------------------------------

As we do not yet officially do componentized releases I follow your proposal to copy the classes, only in the 1.4 branch though and makring them deprecated right from the start.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated JCR-1343:
-----------------------------------

    Fix Version/s: rmi 1.4.1

Schedule for rmi 1.4.1 release as this is a requirement for easy deployment in an OSGi framework such as Sling

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Reopened: (JCR-1343) Replace xerces for serialization by JAXP

Posted by Felix Meschberger <fm...@gmail.com>.
Hi,

Am Donnerstag, den 24.01.2008, 14:58 +0100 schrieb Julian Reschke:
> Felix Meschberger wrote:
> > Hi,
> > 
> > <rant>
> > Hmpf, I like XML in Java - it is more than complicated ....
> > </rant>
> 
> ...it is, in particular when older versions need to be supported.
> 
> > Is this still an issue with today's Java 1.4.2 ? What is the exact
> > dependency on Java 1.4.x of Jackrabbit ?
> 
> 1) Yes, I think that is the case.
> 
> 2) Dunno -- I'd love to simply state that Jackrabbit requires JDK5 :-).

So do I ;-)

Regards
Felix


Re: [jira] Reopened: (JCR-1343) Replace xerces for serialization by JAXP

Posted by Julian Reschke <ju...@gmx.de>.
Felix Meschberger wrote:
> Hi,
> 
> <rant>
> Hmpf, I like XML in Java - it is more than complicated ....
> </rant>

...it is, in particular when older versions need to be supported.

> Is this still an issue with today's Java 1.4.2 ? What is the exact
> dependency on Java 1.4.x of Jackrabbit ?

1) Yes, I think that is the case.

2) Dunno -- I'd love to simply state that Jackrabbit requires JDK5 :-).

> ...

BR, Julian

Re: [jira] Reopened: (JCR-1343) Replace xerces for serialization by JAXP

Posted by Felix Meschberger <fm...@gmail.com>.
Hi,

<rant>
Hmpf, I like XML in Java - it is more than complicated ....
</rant>

Is this still an issue with today's Java 1.4.2 ? What is the exact
dependency on Java 1.4.x of Jackrabbit ?

If we still require this workaround, then this should probably be
located in a well visible location such as jackrabbit-jcr-commons for
all to be accessible.

Regards
Felix

Am Donnerstag, den 24.01.2008, 04:59 -0800 schrieb Jukka Zitting (JIRA):
> [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Jukka Zitting reopened JCR-1343:
> --------------------------------
> 
> 
> We probably need to do something similar to what's being discussed in JCR-1310 to avoid losing namespace declarations in the serialized XML document.
> 
> > Replace xerces for serialization by JAXP
> > ----------------------------------------
> >
> >                 Key: JCR-1343
> >                 URL: https://issues.apache.org/jira/browse/JCR-1343
> >             Project: Jackrabbit
> >          Issue Type: Improvement
> >          Components: jackrabbit-jcr-rmi
> >    Affects Versions: 1.4
> >            Reporter: Felix Meschberger
> >            Assignee: Felix Meschberger
> >             Fix For: 1.5
> >
> >
> > The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.
> 


[jira] Reopened: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting reopened JCR-1343:
--------------------------------


We probably need to do something similar to what's being discussed in JCR-1310 to avoid losing namespace declarations in the serialized XML document.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584735#action_12584735 ] 

Felix Meschberger commented on JCR-1343:
----------------------------------------

In the sense of the considerations in [1] I think, we may well include this dependency in this release:

Therefore, I include this in the 1.4.1 release.

[1] http://markmail.org/message/zva7vih4c3k6br5y

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584745#action_12584745 ] 

Jukka Zitting commented on JCR-1343:
------------------------------------

The patch release should be drop-in compatible with any Jackrabbit 1.4 installation, so I'd very much prefer to avoid the explicit jcr-commons 1.4.2 dependency. If necessary, I'd even copy the relevant classes from jcr-commons in the 1.4 branch to avoid breaking drop-in compatibility.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed JCR-1343.
----------------------------------


Released in jackrabbit-jcr-rmi 1.4.1 release. Closing issue.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1343.
--------------------------------

    Resolution: Fixed

Resolved the namespace declaration issue in revision 616082 by leveraging the new SerializingContentHandler class from JCR-1350.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (JCR-1343) Replace xerces for serialization by JAXP

Posted by Felix Meschberger <fm...@gmail.com>.
Hi Jukka,

I knew that this would start a controversy. But here is my opinion on
that: When doing finer granular releases it may be that an artifact will
have a requirement to another artifact already released in new minor
revision. So it is ok IMHO to have an rmi release 1.4.1 depending on the
commons release 1.4.1.

Looking at the JCR-1350, which is the basis for JCR-1343 to actually
work, it seems like the changes to jcr-commons are local to jcr-commons
and don't seem to have influences on client code of jcr-commons - except
jcr-rmi which exactly depends on these changes.

So at the end of the day, for those requiring an update to rmi 1.4.1
also updating to commons 1.4.1 is not a big issue. Those not updating to
rmi 1.4.1 will not require updating to commons 1.4.1. And finally
updating to commons 1.4.1 has no influence on rmi 1.4 because the
respective code is not used in rmi 1.4.

But then, if the general fealing is to not include JCR-1350 and JCR-1343
in the rmi 1.4.1 and commons 1.4.1 releases, that is also ok.

Other opinions ?

Regards
Felix

Am Donnerstag, den 13.03.2008, 09:58 -0700 schrieb Jukka Zitting (JIRA):
> [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578387#action_12578387 ] 
> 
> Jukka Zitting commented on JCR-1343:
> ------------------------------------
> 
> This should IMHO go to a jackrabbit-jcr-rmi 1.5 release. I'd rather not introduce dependency changes in a patch release...
> 
> > Replace xerces for serialization by JAXP
> > ----------------------------------------
> >
> >                 Key: JCR-1343
> >                 URL: https://issues.apache.org/jira/browse/JCR-1343
> >             Project: Jackrabbit
> >          Issue Type: Improvement
> >          Components: jackrabbit-jcr-rmi
> >    Affects Versions: 1.4
> >            Reporter: Felix Meschberger
> >            Assignee: Felix Meschberger
> >             Fix For: rmi 1.4.1, 1.5
> >
> >
> > The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.
> 


[jira] Commented: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578387#action_12578387 ] 

Jukka Zitting commented on JCR-1343:
------------------------------------

This should IMHO go to a jackrabbit-jcr-rmi 1.5 release. I'd rather not introduce dependency changes in a patch release...

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: rmi 1.4.1, 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JCR-1343) Replace xerces for serialization by JAXP

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed JCR-1343.
----------------------------------

    Resolution: Fixed

Replaced the use of Xerces by JAXP, which causes the following changes:

   * ImportContentHandler constructor throws a RepositoryException if JAXP is not able to
             provide a transform DocumentHandler. Likewise the extended constructors forward
             this exception. This is ok, since the calling methods within the library are declared to
             throw a RepositoryException.

   * Add a very simple testcase to ensure JAXP is used correctly to setup the DocumentHandler.

Implemented in Rev. 614859.

> Replace xerces for serialization by JAXP
> ----------------------------------------
>
>                 Key: JCR-1343
>                 URL: https://issues.apache.org/jira/browse/JCR-1343
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-rmi
>    Affects Versions: 1.4
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: 1.5
>
>
> The org.apache.jackrabbit.rmi.xml.ImportContentHandler class currently uses Xerces to implement the SAX DocumentHandler and serialize XML into a byte[]. This dependency should be dropped and JAXP be used instead for this functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.