You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/06 14:42:40 UTC

[GitHub] [flink] sjwiesman opened a new pull request #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

sjwiesman opened a new pull request #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780
 
 
   ## What is the purpose of the change
   
   The keyed bootstrap operator creates an internal timer service regardless of whether or not timers are used by the bootstrap function. The AbstractStreamOperator has a special case for handling heap-based timers during the snapshot. This case will fail if the operator 1) does not support timers such as Map and FlatMap and 2) the operator contains a timer service. This change makes the creation of the timer service lazy so that keyed Map and FlatMap operators can be bootstrapped by the state proc api. 
   
   ## Brief change log
   
   - Introduce a LazyTimerService
   
   ## Verifying this change
   
   UT
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha closed pull request #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571163863
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e3d428ff8c7933e9c16518db836eddcc401995df (Mon Jan 06 14:44:31 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571250322
 
 
   <!--
   Meta data
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   -->
   ## CI report:
   
   * e3d428ff8c7933e9c16518db836eddcc401995df UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571250322
 
 
   <!--
   Meta data
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4138 TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143281231 TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   -->
   ## CI report:
   
   * e3d428ff8c7933e9c16518db836eddcc401995df Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143281231) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4138) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571250322
 
 
   <!--
   Meta data
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4138 TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143281231 TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   -->
   ## CI report:
   
   * e3d428ff8c7933e9c16518db836eddcc401995df Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143281231) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4138) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571250322
 
 
   <!--
   Meta data
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4138 TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   Hash:e3d428ff8c7933e9c16518db836eddcc401995df Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143281231 TriggerType:PUSH TriggerID:e3d428ff8c7933e9c16518db836eddcc401995df
   -->
   ## CI report:
   
   * e3d428ff8c7933e9c16518db836eddcc401995df Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143281231) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4138) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571643348
 
 
   Thanks for the fix! I merged this ☕

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] sjwiesman commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on issue #10780: [FLINK-15406][state-processor-api] RocksDB savepoints with heap timers cannot be restored by non-process functions
URL: https://github.com/apache/flink/pull/10780#issuecomment-571163796
 
 
   @aljoscha if you have bandwidth this bug fix is small and self contained

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services