Re: [PR] HIVE-22167: TIMESTAMP - Backwards incompatible change: Hive 4 reads back binary RCFILE timestamps written by Hive 2.x incorrectly [hive]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #5952:
URL: https://github.com/apache/hive/pull/5952#issuecomment-3058686091

   
   # @check-spelling-bot Report
   ### :red_circle: Please review
   See the [files](5952/files/) view or the [action log](https://github.com/apache/hive/actions/runs/16204033157) for details.
   
   #### Unrecognized words (2)
   
   RCFILE
   utc
   
   <details><summary>Previously acknowledged words that are now absent
   </summary>aarry bytecode HIVEFETCHOUTPUTSERDE timestamplocal yyyy </details>
   
   <details><summary>To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words),
   run the following commands</summary>
   
   ... in a clone of the [git@github.com:sercanCyberVision/hive.git](https://github.com/sercanCyberVision/hive.git) repository
   on the `HIVE-22167` branch:
   
   ```
   update_files() {
   perl -e '
   my @expect_files=qw('".github/actions/spelling/expect.txt"');
   @ARGV=@expect_files;
   my @stale=qw('"$patch_remove"');
   my $re=join "|", @stale;
   my $suffix=".".time();
   my $previous="";
   sub maybe_unlink { unlink($_[0]) if $_[0]; }
   while (<>) {
   if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
   next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
   }; maybe_unlink($previous);'
   perl -e '
   my $new_expect_file=".github/actions/spelling/expect.txt";
   use File::Path qw(make_path);
   use File::Basename qw(dirname);
   make_path (dirname($new_expect_file));
   open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
   my @add=qw('"$patch_add"');
   my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
   @words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
   open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
   close FILE;
   system("git", "add", $new_expect_file);
   '
   }
   
   comment_json=$(mktemp)
   curl -L -s -S \
   -H "Content-Type: application/json" \
   "https://api.github.com/repos/apache/hive/issues/comments/3058686091" > "$comment_json"
   comment_body=$(mktemp)
   jq -r ".body // empty" "$comment_json" > $comment_body
   rm $comment_json
   
   patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
   
   patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")
   
   update_files
   rm $comment_body
   git add -u
   ```
   </details>
   
   <!--
   {% comment %}
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.
   The ASF licenses this file to you under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
   
   http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
   {% endcomment %}
   -->
   <!-- See https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice --> <!-- markdownlint-disable MD033 MD041 -->
   <details><summary>If the flagged items do not appear to be text</summary>
   
   If items relate to a ...
   * well-formed pattern.
   
     If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it,
     try adding it to the `patterns.txt` file.
   
     Patterns are Perl 5 Regular Expressions - you can [test](
   https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines.
   
     Note that patterns can't match multiline strings.
   
   * binary file.
   
     Please add a file path to the `excludes.txt` file matching the containing file.
   
     File paths are Perl 5 Regular Expressions - you can [test](
   https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files.
   
     `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md](
   ../tree/HEAD/README.md) (on whichever branch you're using).
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org