You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/03 00:59:44 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8720: Require
the SQLAlchemy URI on the database model
codecov-io commented on issue #8720: Require the SQLAlchemy URI on the database model
URL: https://github.com/apache/incubator-superset/pull/8720#issuecomment-560949459
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=h1) Report
> Merging [#8720](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bca2b9141796041e9143fba86bc8a4f82e9076cb?src=pr&el=desc) will **increase** coverage by `5.76%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8720 +/- ##
==========================================
+ Coverage 65.55% 71.32% +5.76%
==========================================
Files 482 122 -360
Lines 24083 12792 -11291
Branches 2763 0 -2763
==========================================
- Hits 15788 9124 -6664
+ Misses 8115 3668 -4447
+ Partials 180 0 -180
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `82.35% <100%> (-0.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `40.74% <0%> (-51.86%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `55.55% <0%> (-27.78%)` | :arrow_down: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `92.91% <0%> (-1.58%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.61% <0%> (-0.21%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.65% <0%> (-0.17%)` | :arrow_down: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| ... and [357 more](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=footer). Last update [bca2b91...8cf95ce](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org