You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 15:01:18 UTC

[GitHub] [arrow-ballista] andygrove opened a new pull request, #453: Bump DataFusion version

andygrove opened a new pull request, #453:
URL: https://github.com/apache/arrow-ballista/pull/453

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   I would like to test some of the bug fixes in DF and see if more of the benchmark queries now work.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1294078071

   LGTM. I cannot approve because I created the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1292647540

   This brings also some improvements to q7 and q19 :partying_face: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1294075264

   Thanks @Dandandan !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] yahoNanJing commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1292868236

   Looks great. One more thing about the format of the datafusion.proto, is there any standard format so that future PRs will not be influenced by the format change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1293081886

   The earlier failing test passes now too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1294077189

   > Looks great. One more thing about the format of the datafusion.proto, is there any standard format so that future PRs will not be influenced by the format change?
   
   Filed https://github.com/apache/arrow-ballista/issues/462 for this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1292635393

   Looks great - I went ahead and fixed the cargo.toml bug - this uncovered some necessary changes needed in the python crate.
   
   I believe the other test is https://github.com/apache/arrow-datafusion/pull/3953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan merged pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan commented on pull request #453: Bump DataFusion version

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #453:
URL: https://github.com/apache/arrow-ballista/pull/453#issuecomment-1293072102

   I also pushed changes to compile python and updated revs.
   Let's see if everything is green now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org