You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2019/04/10 17:50:00 UTC
[jira] [Commented] (SOLR-13389) rectify discrepencies in socket
(and connect) timeout values used throughout the code and tests - probably
helping to reduce TimeoutExceptions in tests
[ https://issues.apache.org/jira/browse/SOLR-13389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814712#comment-16814712 ]
Kevin Risden commented on SOLR-13389:
-------------------------------------
Big plus one from me. I know I looked at this a bit as part of HDFS tests. I am 99% sure what I put is not correct but it fixed some of the HDFS tests.
https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java#L115
This is just conjecture, but I think there might be some weirdness with the HTTP2 handling of sockets compared to HTTP 1.1. I just have that hunch based on some of the errors I've seen.
> rectify discrepencies in socket (and connect) timeout values used throughout the code and tests - probably helping to reduce TimeoutExceptions in tests
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13389
> URL: https://issues.apache.org/jira/browse/SOLR-13389
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Major
>
> While looking into some jenkins test failures caused by distributed requests that timeout, i realized that the "socket timeout" aka "idle timeout" aka "SO_TIMEOUT" values used in various places in the code & sample configs can vary significantly, and in the case of *test* configs/code can differ from the default / production configs by an order of magnitude.
> I think we should consider rectifying some of the various places/ways that different values are sprinkled through out the code to reduce the number of (different) places we have magic constants. I believe a large number of jenkins test failures we currently see due to timeout exceptions are simply because tests (or test configs) override sensible defaults w/values that are too low to be useful.
> (NOTE: all of these problems / discrepancies also apply to "connect timeout" which should probably be addressed at the same time, but for now i'm focusing on the "socket timeout" since it seems to be the bigger problem in jenkins failures -- if we reach consensus on standardizing some values across the board the same approach can be made to connect timeouts at the same time)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org