You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:23:39 UTC

[GitHub] [flink-table-store] tsreaper commented on a change in pull request #70: [FLINK-26971] UniversalCompaction should pick by size ratio after picking by file num

tsreaper commented on a change in pull request #70:
URL: https://github.com/apache/flink-table-store/pull/70#discussion_r840271261



##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/UniversalCompaction.java
##########
@@ -63,7 +63,8 @@ public UniversalCompaction(int maxSizeAmp, int sizeRatio, int maxRunNum) {
         // 3 checking for file num
         if (runs.size() > maxRunNum) {

Review comment:
       Trigger number for this compaction and other compactions should be different (see [rocksdb wiki](https://github.com/facebook/rocksdb/wiki/Universal-Compaction#4-compaction-triggered-by-number-of-sorted-runs-without-respecting-size_ratio)). Add a new option.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org