You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/31 12:44:06 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

cloud-fan commented on a change in pull request #32012:
URL: https://github.com/apache/spark/pull/32012#discussion_r604862863



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4140,6 +4141,21 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
       }
     }
   }
+
+  test("SPARK-34919: Change partitioning to SinglePartition if partition number is 1") {

Review comment:
       since we don't check the result, it's more like a UT. shall we move it to `PlannerSuite`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org