You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2016/04/08 17:22:40 UTC
[GitHub] incubator-metron pull request: Unit tests for configuration relate...
GitHub user merrimanr opened a pull request:
https://github.com/apache/incubator-metron/pull/71
Unit tests for configuration related classes
Tests are providing > 88% coverage on the tested classes. Integration tests and single node vm also tested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-101
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 8e48c92dba2c74dca8fc82ee16a9a30b60be5d94
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-04-07T19:35:30Z
Unit tests for configuration related classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Unit tests for configuration relate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Unit tests for configuration relate...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/71#issuecomment-208541453
@merrimanr We're missing licenses in the following files. Travis passed the PR, since when it was submitted, Travis was broken.
```
Unapproved licenses:
metron-streaming/Metron-Common/src/test/java/org/apache/metron/bolt/BaseBoltTest.java
metron-streaming/Metron-Common/src/test/java/org/apache/metron/bolt/ConfiguredBoltTest.java
metron-streaming/Metron-Common/src/test/java/org/apache/metron/domain/ConfigurationsTest.java
metron-streaming/Metron-Common/src/test/java/org/apache/metron/domain/SensorEnrichmentConfigTest.java
metron-streaming/Metron-Common/src/test/java/org/apache/metron/utils/ConfigurationsUtilsTest.java
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Unit tests for configuration relate...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/71#issuecomment-208629140
+1 perfecto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Unit tests for configuration relate...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/71#issuecomment-208580199
@nickwallen Just pushed a commit with those license headers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---