[jira] [Updated] (SOLR-7599) Remove cruft from SolrCloud tests

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-7599:
----------------------------------------
    Attachment: SOLR-7599.patch

Initial cut which removes all redundant distribSetup and distribTearDown method calls.

[~noble.paul] - Regarding ExternalCollectionsTest -- is it useful anymore given that "external" collections are switched on/off randomly across all tests? Perhaps we should move the .system collection testing to its own test and delete this one.

> Remove cruft from SolrCloud tests
> ---------------------------------
>
>                 Key: SOLR-7599
>                 URL: https://issues.apache.org/jira/browse/SOLR-7599
>             Project: Solr
>          Issue Type: Task
>          Components: SolrCloud, Tests
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Trunk, 5.3
>
>         Attachments: SOLR-7599.patch
>
>
> I see many tests which blindly have distribSetUp and distribTearDown methods setting a variety of options and system properties that aren't required anymore. 
> This is because some base test classes have been refactored such that these options are redundant. In other cases, people have copied the structure of tests blindly instead of understanding what each parameter does.
> Let's try to remove the unnecessary config params from such tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org