You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ns...@apache.org on 2011/10/11 04:02:22 UTC

svn commit: r1181367 - /hbase/branches/0.89/src/main/ruby/hbase/admin.rb

Author: nspiegelberg
Date: Tue Oct 11 02:02:22 2011
New Revision: 1181367

URL: http://svn.apache.org/viewvc?rev=1181367&view=rev
Log:
HBASE-2944: cannot alter bloomfilter setting for a column family from hbase shell

Summary:
Minor fix needed to admin.rb script. When BLOOMFILTER type was changed from
boolean to string, looks like code path was missed.

Test Plan:
Verified that this goes through fine on local cluster...

hbase(main):004:0> alter 't1', {NAME => 'cf', BLOOMFILTER => 'ROW'}
alter 't1', {NAME => 'cf', BLOOMFILTER => 'ROW'}

DiffCamp Revision: 152890
Reviewed By: jgray
CC: jgray, hbase@lists
Revert Plan:
OK

Modified:
    hbase/branches/0.89/src/main/ruby/hbase/admin.rb

Modified: hbase/branches/0.89/src/main/ruby/hbase/admin.rb
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/ruby/hbase/admin.rb?rev=1181367&r1=1181366&r2=1181367&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/ruby/hbase/admin.rb (original)
+++ hbase/branches/0.89/src/main/ruby/hbase/admin.rb Tue Oct 11 02:02:22 2011
@@ -334,7 +334,7 @@ module Hbase
         arg.include?(HColumnDescriptor::BLOCKCACHE)? JBoolean.valueOf(arg[HColumnDescriptor::BLOCKCACHE]): HColumnDescriptor::DEFAULT_BLOCKCACHE,
         arg.include?(HColumnDescriptor::BLOCKSIZE)? JInteger.valueOf(arg[HColumnDescriptor::BLOCKSIZE]): HColumnDescriptor::DEFAULT_BLOCKSIZE,
         arg.include?(HColumnDescriptor::TTL)? JInteger.new(arg[HColumnDescriptor::TTL]): HColumnDescriptor::DEFAULT_TTL,
-        arg.include?(HColumnDescriptor::BLOOMFILTER)? JBoolean.valueOf(arg[HColumnDescriptor::BLOOMFILTER]): HColumnDescriptor::DEFAULT_BLOOMFILTER,
+        arg.include?(HColumnDescriptor::BLOOMFILTER)? arg[HColumnDescriptor::BLOOMFILTER]: HColumnDescriptor::DEFAULT_BLOOMFILTER,
         arg.include?(HColumnDescriptor::REPLICATION_SCOPE)? JInteger.new(arg[REPLICATION_SCOPE]): HColumnDescriptor::DEFAULT_REPLICATION_SCOPE)
     end