You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/05 17:17:22 UTC

[GitHub] [camel] orpiske commented on a diff in pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis

orpiske commented on code in PR #9001:
URL: https://github.com/apache/camel/pull/9001#discussion_r1062708532


##########
components/camel-jms/src/test/java/org/apache/camel/component/jms/ActiveMQOriginalDestinationTest.java:
##########
@@ -55,10 +56,11 @@ public void testActiveMQOriginalDestination() throws Exception {
         JmsMessage msg = out.getIn(JmsMessage.class);
         Message jms = msg.getJmsMessage();
         ActiveMQMessage amq = assertIsInstanceOf(ActiveMQMessage.class, jms);
-        ActiveMQDestination original = amq.getOriginalDestination();
+        ActiveMQDestination original = (ActiveMQDestination) amq.getJMSDestination();
         assertNotNull(original);
-        assertEquals("ActiveMQOriginalDestinationTest", original.getPhysicalName());
-        assertEquals("Queue", original.getDestinationTypeAsString());
+        assertEquals("ActiveMQOriginalDestinationTest.dest", original.getName());
+        //        assertEquals("Queue", original.getDestinationTypeAsString());

Review Comment:
   Maybe remove this commented code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org