[GitHub] [ozone] kuenishi commented on a change in pull request #2433: HDDS-5461. Move old objects to delete table on overwrite

[GitBox <gi...@apache.org>]

kuenishi commented on a change in pull request #2433:
URL: https://github.com/apache/ozone/pull/2433#discussion_r726624765



##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
##########
@@ -442,12 +442,20 @@ public static File createOMDir(String dirPath) {
    *                     of the MultipartUploadAbort request which needs to
    *                     be set as the updateID of the partKeyInfos.
    *                     For regular Key deletes, this value should be set to
-   *                     the same updaeID as is in keyInfo.
+   *                     the same updateID as is in keyInfo.
    * @return {@link RepeatedOmKeyInfo}
    */
   public static RepeatedOmKeyInfo prepareKeyForDelete(OmKeyInfo keyInfo,
       RepeatedOmKeyInfo repeatedOmKeyInfo, long trxnLogIndex,
       boolean isRatisEnabled) {
+
+    // Set the updateID
+    keyInfo.setUpdateID(trxnLogIndex, isRatisEnabled);
+    return prepareKeyForDeleteWithoutUpdateID(keyInfo, repeatedOmKeyInfo);

Review comment:
       Sorry it was the remain of my trial-and-error through working on this task. I'll remove this split.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org