You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Tyler Hobbs (JIRA)" <ji...@apache.org> on 2012/07/30 19:31:34 UTC
[jira] [Created] (THRIFT-1665) TBinaryProtocol: exceeded message
length raises generic TException
Tyler Hobbs created THRIFT-1665:
-----------------------------------
Summary: TBinaryProtocol: exceeded message length raises generic TException
Key: THRIFT-1665
URL: https://issues.apache.org/jira/browse/THRIFT-1665
Project: Thrift
Issue Type: Bug
Components: Java - Library
Affects Versions: 0.8
Reporter: Tyler Hobbs
{{TBinaryProtocol}} allows you to set a {{readLength}} attribute when creating a {{Factory}} (at least in the Java lib). In {{TBinaryProtocol.checkReadLength()}}, if the message length exceeds this, a {{TException}} is raised.
This failure should result in a {{TProtocolException}} instead to make it possible to distinguish some of the error cases. (In particular, it would make it easier for the server to notify the client that it should not reattempt sending the same message.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1665) TBinaryProtocol: exceeded message
length raises generic TException
Posted by "Tyler Hobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425050#comment-13425050 ]
Tyler Hobbs commented on THRIFT-1665:
-------------------------------------
I should add that my assumption was that this change might result in the client seeing a {{TProtocolException}}, but that doesn't appear to be the case after some basic testing. I'll see if I can figure out why, but feel free to suggest another patch.
> TBinaryProtocol: exceeded message length raises generic TException
> ------------------------------------------------------------------
>
> Key: THRIFT-1665
> URL: https://issues.apache.org/jira/browse/THRIFT-1665
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.8
> Reporter: Tyler Hobbs
> Attachments: 1665-java-tprotocolexc.txt
>
>
> {{TBinaryProtocol}} allows you to set a {{readLength}} attribute when creating a {{Factory}} (at least in the Java lib). In {{TBinaryProtocol.checkReadLength()}}, if the message length exceeds this, a {{TException}} is raised.
> This failure should result in a {{TProtocolException}} instead to make it possible to distinguish some of the error cases. (In particular, it would make it easier for the server to notify the client that it should not reattempt sending the same message.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1665) TBinaryProtocol: exceeded message
length raises generic TException
Posted by "Tyler Hobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tyler Hobbs updated THRIFT-1665:
--------------------------------
Attachment: 1665-java-tprotocolexc.txt
Basic patch to use {{TProtocolException}} instead in the java lib.
> TBinaryProtocol: exceeded message length raises generic TException
> ------------------------------------------------------------------
>
> Key: THRIFT-1665
> URL: https://issues.apache.org/jira/browse/THRIFT-1665
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.8
> Reporter: Tyler Hobbs
> Attachments: 1665-java-tprotocolexc.txt
>
>
> {{TBinaryProtocol}} allows you to set a {{readLength}} attribute when creating a {{Factory}} (at least in the Java lib). In {{TBinaryProtocol.checkReadLength()}}, if the message length exceeds this, a {{TException}} is raised.
> This failure should result in a {{TProtocolException}} instead to make it possible to distinguish some of the error cases. (In particular, it would make it easier for the server to notify the client that it should not reattempt sending the same message.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1665) TBinaryProtocol: exceeded message
length raises generic TException
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1665.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.9
Assignee: Tyler Hobbs
I just committed this patch.
> TBinaryProtocol: exceeded message length raises generic TException
> ------------------------------------------------------------------
>
> Key: THRIFT-1665
> URL: https://issues.apache.org/jira/browse/THRIFT-1665
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.8
> Reporter: Tyler Hobbs
> Assignee: Tyler Hobbs
> Fix For: 0.9
>
> Attachments: 1665-java-tprotocolexc.txt
>
>
> {{TBinaryProtocol}} allows you to set a {{readLength}} attribute when creating a {{Factory}} (at least in the Java lib). In {{TBinaryProtocol.checkReadLength()}}, if the message length exceeds this, a {{TException}} is raised.
> This failure should result in a {{TProtocolException}} instead to make it possible to distinguish some of the error cases. (In particular, it would make it easier for the server to notify the client that it should not reattempt sending the same message.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira