You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/01/01 13:54:28 UTC

[GitHub] zeppelin pull request #1830: ZEPPELIN-1867. Update document for pig interpre...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1830

    ZEPPELIN-1867. Update document for pig interpreter and add one sample note

    ### What is this PR for?
    * Minor update for pig interpreter
    * Add one sample pig tutorial note which do the same thing as the spark tutorial note. 
    
    
    ### What type of PR is it?
    [Improvement | Documentation ]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1867
    
    ### How should this be tested?
    Tested manually
    
    ### Screenshots (if appropriate)
    ![image](https://cloud.githubusercontent.com/assets/164491/21581428/d04cb67a-d06c-11e6-85b6-23f006fd6d3a.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1867

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1830
    
----
commit af0375162659436fff00b84f9fd83d22878c842a
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-01-01T09:41:34Z

    ZEPPELIN-1867. Update document for pig interpreter and add one sample note

commit 2bab4633b1fdc0113e6737ae7ebc3cfee77eaa36
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-01-01T13:47:54Z

    Add pig tutorial note

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    Sorry for my late response. It looks nice! Except one minor suggestion, LGTM \U0001f44d 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    @zjffdu Nice! 
    
    In the past `Spark Tutorial` is the only tutorial note in Zeppelin included by default. But after this PR, 5 tutorial notes will be shown to Zeppelin new commers. Since some ppl can try this Pig tutorial before Spark one, more detailed description will be helpful to users than just saying like below 
    <img width="733" alt="screen shot 2017-01-02 at 5 15 33 pm" src="https://cloud.githubusercontent.com/assets/10060731/21586047/1c62f9a0-d10f-11e6-9a41-a368c07dd9ce.png">
    
    
    e.g. short description about Pig / you need to install `hadoop` before trying to run this tutorial note, and etc etc..  
    
    There is good example ([Mahout tutorial note](https://github.com/apache/zeppelin/blob/master/notebook/2BYEZ5EVK/note.json#L4)) you can refer to. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    @AhyoungRyu I have updated the tutorial note, please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    Thanks @AhyoungRyu , I rename the note, please check the updated screenshot in PR description. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    ping @AhyoungRyu , please check the updated screenshot 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    Thanks! Merge into master if there are no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1830
  
    @felixcheung @AhyoungRyu Please help review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1830: ZEPPELIN-1867. Update document for pig interpre...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1830


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---