You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by em...@apache.org on 2020/11/24 01:05:12 UTC

[groovy] branch GROOVY_2_5_X updated: fix for Java 9+

This is an automated email from the ASF dual-hosted git repository.

emilles pushed a commit to branch GROOVY_2_5_X
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/GROOVY_2_5_X by this push:
     new ec7ae98  fix for Java 9+
ec7ae98 is described below

commit ec7ae98dc3638ed70614161ab29e5cc9e92212c2
Author: Eric Milles <er...@thomsonreuters.com>
AuthorDate: Mon Nov 23 19:05:00 2020 -0600

    fix for Java 9+
---
 .../transform/packageScope/DifferentPackageTest.groovy       | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/test/org/codehaus/groovy/transform/packageScope/DifferentPackageTest.groovy b/src/test/org/codehaus/groovy/transform/packageScope/DifferentPackageTest.groovy
index 8709296..02d4e55 100644
--- a/src/test/org/codehaus/groovy/transform/packageScope/DifferentPackageTest.groovy
+++ b/src/test/org/codehaus/groovy/transform/packageScope/DifferentPackageTest.groovy
@@ -54,7 +54,7 @@ final class DifferentPackageTest {
     //--------------------------------------------------------------------------
 
     @Test
-    void testSamePackageShouldSeeInstanceProps1() {
+    void testSamePackageShouldSeeObjectProps1() {
         def loader = addSources(
             One: P_DOT_ONE,
             Two: '''
@@ -72,7 +72,7 @@ final class DifferentPackageTest {
     }
 
     @Test
-    void testSamePackageShouldSeeInstanceProps2() {
+    void testSamePackageShouldSeeObjectProps2() {
         def loader = addSources(
             One: P_DOT_ONE,
             Peer: '''
@@ -187,7 +187,7 @@ final class DifferentPackageTest {
     }
 
     @Test // GROOVY-9093
-    void testDifferentPackageShouldNotSeeInstanceProps() {
+    void testDifferentPackageShouldNotSeeObjectProps1() {
         def loader = addSources(
             One: P_DOT_ONE,
             Two: '''
@@ -200,8 +200,10 @@ final class DifferentPackageTest {
                     }
                 }
             ''')
-        // TODO: Don't need this once compiler errors
-        assert loader.loadClass('q.Two').newInstance().valueSize() == 5
+        try { // TODO: Don't need this once compiler emits error
+            assert loader.loadClass('q.Two').newInstance().valueSize() == 5
+        } catch (MissingPropertyException java9plus) {
+        }
     }
 
     @Test // GROOVY-9093