[GitHub] [sling-org-apache-sling-serviceusermapper] bdelacretaz commented on a change in pull request #2: SLING-10099 : Validators should all agree for a service user to be valid and should be configurable

[GitBox <gi...@apache.org>]

bdelacretaz commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/2#discussion_r566137928



##########
File path: src/main/java/org/apache/sling/serviceusermapping/impl/ServiceUserMapperImpl.java
##########
@@ -85,7 +87,13 @@
                      "default mapping is applied which uses the service user \"serviceuser--\" + bundleId + [\"--\" + subServiceName]")
         boolean user_enable_default_mapping() default true;
 
+        @AttributeDefinition(name = "Require Validation",
+                description = "Do validators have to be present and validate the service users?")
         boolean require_validation() default false;
+
+        @AttributeDefinition(name = "Required Validators",
+                description = "A list of required validators ids. If not present and require validation is on not user will be valid")

Review comment:
       If would also add quotes on 'require validation', so maybe
   
   > A list of required validators IDs. If this is empty and 'require validation' is enabled, validation will fail for all users and principals




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org