You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/03/22 04:00:23 UTC
[GitHub] [arrow] kou opened a new pull request, #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
kou opened a new pull request, #34674:
URL: https://github.com/apache/arrow/pull/34674
### Rationale for this change
Homebrew uses symbolic link for `$(brew --prefix)/include/arrow`. The current code doesn't work with it because `install(DIRECTORY)` accepts a directory not a symbolic link.
### What changes are included in this PR?
This changes use resolved path instead of symbolic link.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1478888144
* Closes: #34395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser merged pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #34674:
URL: https://github.com/apache/arrow/pull/34674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1479412135
Revision: 9b474a11a87ea24f48a75c9d958b97df74bc32ea
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a23c33a6ce](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a23c33a6ce)
|Task|Status|
|----|------|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/12189581332)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1479409468
@github-actions crossbow submit conda-win-x64-cpu-py3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1480272661
Feedback from users is appreciated but we can merge this without it. Because I could reproduce this on my local macOS and confirmed that the problem is fixed with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1478888434
@github-actions crossbow submit -g conda -g wheel -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1481212503
Benchmark runs are scheduled for baseline = 4487be02763ff19c14c9d56809907284e51b513d and contender = 7ae236c1fa74d4812f2312a5dff2babfc6baeffe. 7ae236c1fa74d4812f2312a5dff2babfc6baeffe is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/35029a82eb364b368bf18747e09c04c0...cfe2529ed32e402e88617e8cffd84259/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d478d44c350f48d097aeccc2100c2e23...d1979c05d35041b2a6cfa4fadd3ec066/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/41ef043fe41642bbb7da57ce60b250c9...6a58292d86454809b01434ed0eb22f81/)
[Finished :arrow_down:0.16% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7e9cff3f90b44e3d88109f23a3e646a1...085f141f84be4593a323bb35b9b9c522/)
Buildkite builds:
[Finished] [`7ae236c1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2561)
[Finished] [`7ae236c1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2591)
[Finished] [`7ae236c1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2559)
[Finished] [`7ae236c1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2582)
[Finished] [`4487be02` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2560)
[Finished] [`4487be02` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2590)
[Finished] [`4487be02` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2558)
[Finished] [`4487be02` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2581)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1478888172
:warning: GitHub issue #34395 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34674: GH-34395: [Python] Add support for symbolic linked Arrow related include directories
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34674:
URL: https://github.com/apache/arrow/pull/34674#issuecomment-1478892809
Revision: 9b474a11a87ea24f48a75c9d958b97df74bc32ea
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9b912290a4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9b912290a4)
|Task|Status|
|----|------|
|conda-clean|[](https://github.com/ursacomputing/crossbow/tree/actions-9b912290a4-azure-conda-clean)|
|conda-linux-aarch64-cpu-py3|[](https://github.com/ursacomputing/crossbow/tree/actions-9b912290a4-azure-conda-linux-aarch64-cpu-py3)|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/12181149420)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/12181158629)|
|conda-linux-ppc64le-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/12181148970)|
|conda-linux-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/12181166032)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/12181141813)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/12181161267)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/12181159741)|
|conda-osx-arm64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/12181141218)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/12181155568)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/12181148206)|
|conda-osx-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/12181143686)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/12181144938)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/12181139252)|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/12181146927)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/12181166346)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/12181152972)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/4486312944/jobs/7888688234)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/4486309061/jobs/7888679454)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions/runs/4486309535/jobs/7888680420)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/4486310868/jobs/7888683878)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/4486306250/jobs/7888674419)|
|test-conda-python-3.7-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/4486309300/jobs/7888679917)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4486310921/jobs/7888684143)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/4486314037/jobs/7888690228)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/4486311822/jobs/7888686024)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/4486313710/jobs/7888689750)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4486312131/jobs/7888686663)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/4486307917/jobs/7888677495)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/4486305295/jobs/7888671862)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/4486306149/jobs/7888674062)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4486303295/jobs/7888667892)|
|test-conda-python-3.9-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/4486307471/jobs/7888676669)|
|test-conda-python-3.9-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/4486305641/jobs/7888672666)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/4486312380/jobs/7888687130)|
|test-conda-python-3.9-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/4486311547/jobs/7888685519)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/4486310700/jobs/7888683443)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/12181137644)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/12181163046)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/12181159163)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486303770/jobs/7888668722)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486306588/jobs/7888675064)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486306047/jobs/7888673769)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486310651/jobs/7888683287)|
|wheel-macos-mojave-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486304921/jobs/7888670926)|
|wheel-macos-mojave-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486313231/jobs/7888688768)|
|wheel-macos-mojave-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486305928/jobs/7888673391)|
|wheel-macos-mojave-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486308509/jobs/7888678448)|
|wheel-macos-mojave-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486313469/jobs/7888690352)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486304307/jobs/7888669610)|
|wheel-manylinux2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/runs/12181142558)|
|wheel-manylinux2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486310333/jobs/7888682342)|
|wheel-manylinux2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/runs/12181154009)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486304068/jobs/7888669318)|
|wheel-manylinux2014-cp37-arm64|[](https://github.com/ursacomputing/crossbow/runs/12181141640)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486307719/jobs/7888677156)|
|wheel-manylinux2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/runs/12181154321)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486311297/jobs/7888685050)|
|wheel-manylinux2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/runs/12181155619)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486305533/jobs/7888672442)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486303034/jobs/7888667593)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486313887/jobs/7888689945)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486310885/jobs/7888683913)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4486306773/jobs/7888675365)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org