You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "jaideeppyne (via GitHub)" <gi...@apache.org> on 2026/09/16 05:12:14 UTC
[PR] fix(tdigest): preserve stored min and max when merging (datasketches-rust)
jaideeppyne opened a new pull request, #280:
URL: https://github.com/apache/datasketches-rust/pull/280
Fixes #277.
## Summary
- Copy the stored `min` / `max` from the other digest in `TDigestMut::merge` before compressing the combined centroid list.
- Add a regression that merges a deserialized image whose extreme centroids have weight > 1 (so their means are not the true extrema).
- Document the bug fix in the changelog.
## Why
Compression never merges the extreme centroids for digests built through `update`, so this is invisible on that path. Reference-format and other deserialized images can store min/max strictly outside the extreme centroid means. `merge` previously ignored those fields and re-derived extrema from centroid means, so:
- `min_value()` / `max_value()` drifted inward
- rank / quantile tail interpolation used the wrong endpoints
This is the same class of tail-interpolation defect as #250, on the merge path rather than the query formulas.
## Validation
- `cargo test -p tests-integration --test tdigest_test`
- `cargo +nightly clippy -p datasketches --all-features -- -D warnings`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] fix(tdigest): preserve stored min and max when merging (datasketches-rust)
Posted by "jaideeppyne (via GitHub)" <gi...@apache.org>.
jaideeppyne commented on PR #280:
URL: https://github.com/apache/datasketches-rust/pull/280#issuecomment-5692521113
Closing as duplicate of #279 (same #277 fix).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] fix(tdigest): preserve stored min and max when merging (datasketches-rust)
Posted by "jaideeppyne (via GitHub)" <gi...@apache.org>.
jaideeppyne closed pull request #280: fix(tdigest): preserve stored min and max when merging
URL: https://github.com/apache/datasketches-rust/pull/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org