You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by na...@apache.org on 2016/04/19 16:55:09 UTC
jclouds git commit: Revert "Add FalseOnNotFoundOr204 Fallback"
Repository: jclouds
Updated Branches:
refs/heads/master 3cf4e3d79 -> e5f65a479
Revert "Add FalseOnNotFoundOr204 Fallback"
This fallback was added by mistake and because of my bad advice
on a code review. Fallbacks only apply for failed responses which
status code is >= 300, so a fallback for a 204 would never
be triggered.
This reverts commit e65950b8583a8b8694972029e34f6220fedfeac8.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/e5f65a47
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/e5f65a47
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/e5f65a47
Branch: refs/heads/master
Commit: e5f65a4791d82e394b00af49bce30985bea04a6c
Parents: 3cf4e3d
Author: Ignasi Barrera <na...@apache.org>
Authored: Tue Apr 19 16:36:30 2016 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Tue Apr 19 16:36:30 2016 +0200
----------------------------------------------------------------------
core/src/main/java/org/jclouds/Fallbacks.java | 9 ---------
1 file changed, 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/e5f65a47/core/src/main/java/org/jclouds/Fallbacks.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/jclouds/Fallbacks.java b/core/src/main/java/org/jclouds/Fallbacks.java
index c3620be..823e5ea 100644
--- a/core/src/main/java/org/jclouds/Fallbacks.java
+++ b/core/src/main/java/org/jclouds/Fallbacks.java
@@ -75,15 +75,6 @@ public final class Fallbacks {
}
}
- public static final class FalseOnNotFoundOr204 implements Fallback<Boolean> {
- public Boolean createOrPropagate(Throwable t) throws Exception {
- if (containsResourceNotFoundException(checkNotNull(t, "throwable"))
- || returnValueOnCodeOrNull(t, true, equalTo(204)) != null)
- return false;
- throw propagate(t);
- }
- }
-
/**
*/
public static final class AbsentOn403Or404Or500 implements Fallback<Optional<Object>> {