[jira] [Commented] (NIFI-858) Remove 'nifi-assembly' and just make that part of the top level 'nifi' project

["Joseph Witt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698817#comment-14698817 ] 

Joseph Witt commented on NIFI-858:
----------------------------------

Great points by sean busbey suggesting an alternative approach:

It's been easier, in my experience, to properly work out maven tooling to
build assemblies with all of the needed legal bits via a dedicated assembly
submodule rather than having it at the top level.

Consider build order. The assembly should have a dependency on all the
modules it includes so that maven knows to build it last. If the assembly
is at the top pom and that pom is the parent for the submodules it
contains, how does that work out?

What if we just had a flag (default true) that controlled copying the
finished assembly to a top level target directory?

> Remove 'nifi-assembly' and just make that part of the top level 'nifi' project
> ------------------------------------------------------------------------------
>
>                 Key: NIFI-858
>                 URL: https://issues.apache.org/jira/browse/NIFI-858
>             Project: Apache NiFi
>          Issue Type: Task
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Minor
>             Fix For: 0.3.0
>
>
> It was suggested by a nifi user that the nifi-assembly project seems unnecessary and that it was more intuitive for the assembly build of the project to just occur in the root level of 'nifi'.
> I recall why we did this long ago and I believe it may no longer apply in the apache context so I like this idea if it makes things easier for others.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)