[jira] [Commented] (BAHIR-203) Pubsub manual acknowledgement

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BAHIR-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842785#comment-16842785 ] 

ASF GitHub Bot commented on BAHIR-203:
--------------------------------------

lresende commented on pull request #85: [BAHIR-203] Manual acknowledge PubSub messages
URL: https://github.com/apache/bahir/pull/85
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Pubsub manual acknowledgement 
> ------------------------------
>
>                 Key: BAHIR-203
>                 URL: https://issues.apache.org/jira/browse/BAHIR-203
>             Project: Bahir
>          Issue Type: Improvement
>          Components: Spark Streaming Connectors
>            Reporter: Danny Tachev
>            Priority: Minor
>             Fix For: Spark-2.3.0, Spark-2.4.0
>
>
> Hi, 
> We have a use case where acknowledgement has to be sent at a later stage when streaming data from google pubsub. Any chance for the acknowledgement in PubsubReceiver to be made optional and ackId to be included in the SparkPubsubMessage model?
> Example:
> {code:java}
> store(receivedMessages
>     .map(x => {
>       val sm = new SparkPubsubMessage
>       sm.message = x.getMessage
>       sm.ackId = x.getAckId
>       sm
>     })
>     .iterator)
> if ( ... ) {
>   val ackRequest = new AcknowledgeRequest()
>   ackRequest.setAckIds(receivedMessages.map(x => x.getAckId).asJava)
>   client.projects().subscriptions().acknowledge(subscriptionFullName, ackRequest).execute()
> }{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)