You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2016/06/24 23:32:20 UTC

[GitHub] flink issue #2150: [FLINK-3580] [table] Reintroduce Date/Time and implement ...

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2150
  
    Hi @twalthr, thanks for the PR. I skimmed the changes and everything looked fine. I have two suggestions though. 
    
    1. Can we add a casts from `Long` to `Timestamp` and back? 
    2. Can you add a Date, Time, and Timestamp type an existing ITCase for Scala SQL and Table API to check that these work fine?
    
    Thanks, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---