[GitHub] [nifi] nandorsoma commented on a diff in pull request #6447: NIFI-10543 Support broker failover in MQTT processors

[GitBox <gi...@apache.org>]

nandorsoma commented on code in PR #6447:
URL: https://github.com/apache/nifi/pull/6447#discussion_r979484054


##########
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java:
##########
@@ -624,8 +619,8 @@ private void closeWriter(final RecordSetWriter writer) {
     }
 
     private String getTransitUri(String... appends) {
-        String broker = clientProperties.getBrokerUri().toString();
-        StringBuilder stringBuilder = new StringBuilder(broker.endsWith("/") ? broker : broker + "/");
+        final String broker = clientProperties.getRawBrokerUris();

Review Comment:
   I don't think that the transitUri produced a valid URI in the original version, when more than one parameter were passed as an argument. It probably needs to be fixed, and we also need to think about how we want to represent a cluster URI here. Now its `ssl://localhost:1883,ssl://localhost:1884/` + `appends`, but I'm wondering if it would make sense to specify a cluster in the broker URI parameter as `ssl://[localhost:1883,localhost:1883]` since the scheme should be the same. This way, the same scheme validation could be spared.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org