You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2010/12/01 05:43:10 UTC

[jira] Created: (CASSANDRA-1795) [patch] avoid unnecessary use of synchronized collection for non escaped local varables

[patch] avoid unnecessary use of synchronized collection for non escaped local varables
---------------------------------------------------------------------------------------

                 Key: CASSANDRA-1795
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1795
             Project: Cassandra
          Issue Type: Improvement
         Environment: ubuntu jdk1..6.17 ant 1.8
            Reporter: Dave Brosius
            Priority: Trivial
         Attachments: avoid_local_sync_collections.diff

code uses a Hashtable even tho the collection is a local variable that is not escaped from the method. The synchronization is not needed, switch to HashMap.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (CASSANDRA-1795) [patch] avoid unnecessary use of synchronized collection for non escaped local varables

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-1795.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7.0
         Reviewer: jbellis
         Assignee: Dave Brosius

committed, thanks!

> [patch] avoid unnecessary use of synchronized collection for non escaped local varables
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1795
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1795
>             Project: Cassandra
>          Issue Type: Improvement
>         Environment: ubuntu jdk1..6.17 ant 1.8
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.7.0
>
>         Attachments: avoid_local_sync_collections.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code uses a Hashtable even tho the collection is a local variable that is not escaped from the method. The synchronization is not needed, switch to HashMap.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CASSANDRA-1795) [patch] avoid unnecessary use of synchronized collection for non escaped local varables

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated CASSANDRA-1795:
------------------------------------

    Attachment: avoid_local_sync_collections.diff

> [patch] avoid unnecessary use of synchronized collection for non escaped local varables
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1795
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1795
>             Project: Cassandra
>          Issue Type: Improvement
>         Environment: ubuntu jdk1..6.17 ant 1.8
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: avoid_local_sync_collections.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code uses a Hashtable even tho the collection is a local variable that is not escaped from the method. The synchronization is not needed, switch to HashMap.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CASSANDRA-1795) [patch] avoid unnecessary use of synchronized collection for non escaped local varables

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970403#action_12970403 ] 

Hudson commented on CASSANDRA-1795:
-----------------------------------

Integrated in Cassandra-0.7 #70 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/70/])
    

> [patch] avoid unnecessary use of synchronized collection for non escaped local varables
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1795
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1795
>             Project: Cassandra
>          Issue Type: Improvement
>         Environment: ubuntu jdk1..6.17 ant 1.8
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.7.0 rc 2
>
>         Attachments: avoid_local_sync_collections.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code uses a Hashtable even tho the collection is a local variable that is not escaped from the method. The synchronization is not needed, switch to HashMap.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.