You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2015/07/04 09:28:09 UTC
[jira] [Updated] (SPARK-8541) sumApprox and meanApprox doctests are
incorrect
[ https://issues.apache.org/jira/browse/SPARK-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated SPARK-8541:
-----------------------------
Fix Version/s: (was: 1.4.2)
(was: 1.3.2)
1.4.1
> sumApprox and meanApprox doctests are incorrect
> -----------------------------------------------
>
> Key: SPARK-8541
> URL: https://issues.apache.org/jira/browse/SPARK-8541
> Project: Spark
> Issue Type: Test
> Components: PySpark
> Affects Versions: 1.3.1, 1.4.0
> Reporter: Scott Taylor
> Assignee: Scott Taylor
> Priority: Minor
> Labels: tests
> Fix For: 1.4.1, 1.5.0
>
>
> The doctests for sumApprox and meanApprox methods test against an upper bound but not a lower bound. If there was a regression in the underlying code that caused things to go wrong the doctest may not fail. For example if sumApprox returned 0 the doctest would return -1 which is less than 0.05. Solution is to use the abs() function to test that the approximate answer is within 5% of the exact answer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org