You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/14 06:50:59 UTC

[GitHub] [rocketmq] drpmma opened a new pull request, #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable

drpmma opened a new pull request, #4459:
URL: https://github.com/apache/rocketmq/pull/4459

   ## What is the purpose of the change
   
   Change PullMessageRequestHeader maxMsgNums to CFNullable to ensure protocol compatibility.
   
   ## Brief changelog
   
   See https://github.com/apache/rocketmq/blob/82a48be00a6d9def14abb871a40cb68cf8a041e9/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java#L277


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhouxinyu merged pull request #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable

Posted by GitBox <gi...@apache.org>.
zhouxinyu merged PR #4459:
URL: https://github.com/apache/rocketmq/pull/4459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhouxinyu commented on pull request #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable

Posted by GitBox <gi...@apache.org>.
zhouxinyu commented on PR #4459:
URL: https://github.com/apache/rocketmq/pull/4459#issuecomment-1154812196

   LGTM~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org