You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2021/09/13 16:39:00 UTC

[jira] [Resolved] (CALCITE-4766) Remove unreachable code from SqlValidatorImpl#performUnconditionalRewrites for VALUES node

     [ https://issues.apache.org/jira/browse/CALCITE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis resolved CALCITE-4766.
------------------------------------------
    Fix Version/s: 1.28.0
       Resolution: Fixed

Fixed in [d7e20baf3920b9e8cd1e2171b98209ef57368216|https://github.com/apache/calcite/commit/d7e20baf3920b9e8cd1e2171b98209ef57368216]. Thanks for the PR [~Lam167]!

> Remove unreachable code from SqlValidatorImpl#performUnconditionalRewrites for VALUES node
> ------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4766
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4766
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Jianhui Dong
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>         Attachments: image-2021-09-08-15-46-09-395.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> in SqlValidatorImpl line 1387, there is a line `if (underFrom || true)`:
> !image-2021-09-08-15-46-09-395.png!
> The condition is always true and I think we can remove this condition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)