You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/05/13 21:19:12 UTC
Review Request 47358: GEODE-1393 locator returns incorrect server
information when starting up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47358/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jon Chen, Udo Kohlmeyer, and Dan Smith.
Repository: geode
Description
-------
When a locator starts up it has no knowledge of what cache servers are in the system. It doesn't know this until it has received at least on load update from the servers. This can cause clients to throw a NoAvailableServersException, and it's probably why we see these inexplicable exceptions in test failures from time to time.
I've rewritten ServerLocator.processRequest() to allow early handling of locator location requests and to disallow early handling of server location requests.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java d42a2b45a4383931318e97bf0575e084ef4aa7ed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java e535b97688e74ce30b259cbe78c9921db9ba9c13
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/ServerLocatorJUnitTest.java bb83df95d20b7146509a00a10a3b12cc923c97c4
Diff: https://reviews.apache.org/r/47358/diff/
Testing
-------
New unit test. Precheckin is underway.
Thanks,
Bruce Schuchardt
Re: Review Request 47358: GEODE-1393 locator returns incorrect server
information when starting up
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On May 13, 2016, 10:05 p.m., Jianxia Chen wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java, line 213
> > <https://reviews.apache.org/r/47358/diff/1/?file=1383145#file1383145line213>
> >
> > GEODE-1393
thanks for catching that :)
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47358/#review133207
-----------------------------------------------------------
On May 13, 2016, 10:36 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47358/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 10:36 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When a locator starts up it has no knowledge of what cache servers are in the system. It doesn't know this until it has received at least on load update from the servers. This can cause clients to throw a NoAvailableServersException, and it's probably why we see these inexplicable exceptions in test failures from time to time.
>
> I've rewritten ServerLocator.processRequest() to allow early handling of locator location requests and to disallow early handling of server location requests.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java d42a2b45a4383931318e97bf0575e084ef4aa7ed
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java e535b97688e74ce30b259cbe78c9921db9ba9c13
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/ServerLocatorJUnitTest.java bb83df95d20b7146509a00a10a3b12cc923c97c4
>
> Diff: https://reviews.apache.org/r/47358/diff/
>
>
> Testing
> -------
>
> New unit test. Precheckin is underway.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 47358: GEODE-1393 locator returns incorrect server
information when starting up
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47358/#review133207
-----------------------------------------------------------
Fix it, then Ship it!
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java (line 211)
<https://reviews.apache.org/r/47358/#comment197505>
GEODE-1393
- Jianxia Chen
On May 13, 2016, 9:19 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47358/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 9:19 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jon Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When a locator starts up it has no knowledge of what cache servers are in the system. It doesn't know this until it has received at least on load update from the servers. This can cause clients to throw a NoAvailableServersException, and it's probably why we see these inexplicable exceptions in test failures from time to time.
>
> I've rewritten ServerLocator.processRequest() to allow early handling of locator location requests and to disallow early handling of server location requests.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java d42a2b45a4383931318e97bf0575e084ef4aa7ed
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java e535b97688e74ce30b259cbe78c9921db9ba9c13
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/ServerLocatorJUnitTest.java bb83df95d20b7146509a00a10a3b12cc923c97c4
>
> Diff: https://reviews.apache.org/r/47358/diff/
>
>
> Testing
> -------
>
> New unit test. Precheckin is underway.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>