You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2026/01/14 08:34:10 UTC
[PR] [enhancement](config) remove oom validator in config.cpp [doris]
yiguolei opened a new pull request, #59874:
URL: https://github.com/apache/doris/pull/59874
### What problem does this PR solve?
This pr forget to remove validator https://github.com/apache/doris/pull/58669/files
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748413381
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #59874:
URL: https://github.com/apache/doris/pull/59874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3758335832
skip check_coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748715531
<details>
<summary>TPC-H: <b>Total hot run time: 31622 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e9b2c4c418ab3ac31c095f35b9bff123a6f316c4, data reload: false
------ Round 1 ----------------------------------
q1 17628 4283 4031 4031
q2 2051 360 250 250
q3 10138 1347 755 755
q4 10299 960 318 318
q5 8661 2133 1865 1865
q6 231 170 134 134
q7 959 823 681 681
q8 9316 1398 1236 1236
q9 4828 4575 4545 4545
q10 6769 1776 1424 1424
q11 507 283 268 268
q12 679 725 597 597
q13 17812 3799 3099 3099
q14 296 303 275 275
q15 591 511 508 508
q16 682 685 638 638
q17 647 748 572 572
q18 6774 6541 6335 6335
q19 1245 993 628 628
q20 420 365 240 240
q21 3038 2447 2262 2262
q22 1026 1035 961 961
Total cold run time: 104597 ms
Total hot run time: 31622 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4137 4051 4053 4051
q2 330 409 334 334
q3 2099 2611 2210 2210
q4 1311 1769 1295 1295
q5 4149 4090 4062 4062
q6 210 167 125 125
q7 1934 1816 1653 1653
q8 2484 2322 2257 2257
q9 6681 6740 6657 6657
q10 2346 2582 2100 2100
q11 541 479 438 438
q12 646 723 598 598
q13 3305 3807 3044 3044
q14 278 284 262 262
q15 539 506 500 500
q16 619 655 630 630
q17 1116 1318 1289 1289
q18 7577 7140 7369 7140
q19 842 808 810 808
q20 1877 1961 1809 1809
q21 4474 4212 4086 4086
q22 1073 1049 976 976
Total cold run time: 48568 ms
Total hot run time: 46324 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748780328
<details>
<summary>ClickBench: <b>Total hot run time: 26.83 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e9b2c4c418ab3ac31c095f35b9bff123a6f316c4, data reload: false
query1 0.06 0.04 0.04
query2 0.09 0.05 0.04
query3 0.28 0.09 0.08
query4 1.61 0.12 0.11
query5 0.27 0.26 0.26
query6 1.15 0.66 0.64
query7 0.03 0.03 0.02
query8 0.06 0.04 0.04
query9 0.56 0.50 0.49
query10 0.56 0.55 0.54
query11 0.15 0.10 0.10
query12 0.15 0.11 0.11
query13 0.61 0.59 0.58
query14 0.97 0.95 0.94
query15 0.80 0.78 0.78
query16 0.40 0.38 0.39
query17 1.06 1.04 1.05
query18 0.23 0.20 0.21
query19 1.98 1.89 1.90
query20 0.02 0.01 0.01
query21 15.44 0.25 0.14
query22 5.27 0.05 0.05
query23 16.16 0.29 0.11
query24 1.02 0.58 0.23
query25 0.06 0.06 0.09
query26 0.14 0.14 0.13
query27 0.06 0.06 0.09
query28 3.81 1.08 0.88
query29 12.51 3.97 3.13
query30 0.28 0.14 0.12
query31 2.82 0.64 0.39
query32 3.24 0.55 0.45
query33 3.00 3.00 3.05
query34 16.08 5.13 4.47
query35 4.48 4.46 4.46
query36 0.64 0.51 0.51
query37 0.10 0.06 0.06
query38 0.08 0.04 0.04
query39 0.05 0.03 0.03
query40 0.18 0.14 0.13
query41 0.10 0.04 0.03
query42 0.05 0.04 0.03
query43 0.04 0.03 0.04
Total cold run time: 96.65 s
Total hot run time: 26.83 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748756553
<details>
<summary>TPC-DS: <b>Total hot run time: 173838 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e9b2c4c418ab3ac31c095f35b9bff123a6f316c4, data reload: false
query5 5055 620 479 479
query6 418 226 216 216
query7 5373 468 250 250
query8 370 234 238 234
query9 8261 2883 2894 2883
query10 612 364 345 345
query11 15081 15104 14789 14789
query12 164 116 113 113
query13 1231 477 391 391
query14 5637 2988 2737 2737
query14_1 2658 2612 2627 2612
query15 205 191 178 178
query16 933 495 475 475
query17 873 667 570 570
query18 2224 434 329 329
query19 219 220 198 198
query20 120 120 119 119
query21 181 136 128 128
query22 3996 4338 4304 4304
query23 16073 15795 15438 15438
query23_1 15679 15587 15536 15536
query24 5859 1545 1180 1180
query24_1 1170 1143 1179 1143
query25 454 441 370 370
query26 872 260 150 150
query27 2853 449 274 274
query28 4516 2132 2115 2115
query29 802 528 409 409
query30 299 233 213 213
query31 799 640 552 552
query32 76 75 73 73
query33 535 350 299 299
query34 872 905 523 523
query35 705 759 689 689
query36 879 909 833 833
query37 130 95 81 81
query38 2724 2636 2633 2633
query39 785 745 747 745
query39_1 718 716 703 703
query40 220 143 118 118
query41 64 61 66 61
query42 104 99 101 99
query43 453 445 429 429
query44 1313 734 732 732
query45 186 185 175 175
query46 837 947 565 565
query47 1524 1515 1430 1430
query48 318 322 243 243
query49 598 432 336 336
query50 602 264 204 204
query51 3747 3814 3696 3696
query52 104 106 93 93
query53 290 327 275 275
query54 293 269 254 254
query55 82 76 77 76
query56 309 306 309 306
query57 995 1040 908 908
query58 260 257 248 248
query59 1953 2150 1965 1965
query60 331 332 309 309
query61 160 149 153 149
query62 384 364 324 324
query63 291 263 260 260
query64 4842 1402 1083 1083
query65 3818 3803 3786 3786
query66 1455 435 334 334
query67 14995 15694 14774 14774
query68 2699 1015 749 749
query69 462 375 336 336
query70 1010 963 943 943
query71 323 324 289 289
query72 5738 3402 3211 3211
query73 554 666 308 308
query74 8712 8734 8600 8600
query75 2707 2824 2457 2457
query76 2449 1047 649 649
query77 366 375 304 304
query78 9922 9861 9174 9174
query79 2068 883 617 617
query80 1515 563 502 502
query81 553 262 229 229
query82 485 149 109 109
query83 389 252 241 241
query84 299 116 95 95
query85 938 513 445 445
query86 472 301 296 296
query87 2814 2845 2762 2762
query88 3486 2607 2547 2547
query89 404 340 317 317
query90 1958 173 157 157
query91 178 162 140 140
query92 77 72 71 71
query93 1182 899 516 516
query94 647 316 283 283
query95 579 327 380 327
query96 632 505 236 236
query97 2335 2374 2309 2309
query98 204 204 193 193
query99 583 585 511 511
Total cold run time: 240952 ms
Total hot run time: 173838 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748413853
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748987489
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748987745
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](config) remove oom validator in config.cpp [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59874:
URL: https://github.com/apache/doris/pull/59874#issuecomment-3748675711
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e9b2c4c418ab3ac31c095f35b9bff123a6f316c4_e9b2c4c418ab3ac31c095f35b9bff123a6f316c4/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e9b2c4c418ab3ac31c095f35b9bff123a6f316c4_e9b2c4c418ab3ac31c095f35b9bff123a6f316c4/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.99% (18985/35826) |
| Line Coverage | 39.02% (175878/450688) |
| Region Coverage | 33.62% (136267/405296) |
| Branch Coverage | 34.65% (58909/169999) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org