You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/04/10 13:01:25 UTC
Review Request: Enhance resize volume tests to support xenserver hypervisor
and fix few test flow errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10393/
-----------------------------------------------------------
Review request for cloudstack and Marcus Sorensen.
Description
-------
Based on hypervisor, resizeVolume needs VM to be in stopped state for xenserver.
Earlier tests had volume not attached, Hence, resize is failing
This addresses bug CLOUDSTACK-1995.
Diffs
-----
test/integration/smoke/1 PRE-CREATION
test/integration/smoke/test_volumes.py 36eb5de
Diff: https://reviews.apache.org/r/10393/diff/
Testing
-------
Tested with KVM and XenServer hypervisors with local storage. I couldn't test on shared storage because of a bug related to primary storage
Thanks,
SrikanteswaraRao Talluri
Re: Review Request: Enhance resize volume tests to support xenserver
hypervisor and fix few test flow errors
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On April 12, 2013, 8:33 a.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_volumes.py, line 570
> > <https://reviews.apache.org/r/10393/diff/1/?file=280213#file280213line570>
> >
> > Why would a sleep be required here? Can you add a comment for why?
removed it
> On April 12, 2013, 8:33 a.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_volumes.py, line 576
> > <https://reviews.apache.org/r/10393/diff/1/?file=280213#file280213line576>
> >
> > This sleep can also be removed since virtual_machine.stop returns only after the VM moves to stopped state.
removed it
> On April 12, 2013, 8:33 a.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_volumes.py, line 612
> > <https://reviews.apache.org/r/10393/diff/1/?file=280213#file280213line612>
> >
> > Same as above.
removed it
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10393/#review19057
-----------------------------------------------------------
On April 15, 2013, 6:08 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10393/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 6:08 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen.
>
>
> Description
> -------
>
> Based on hypervisor, resizeVolume needs VM to be in stopped state for xenserver.
>
> Earlier tests had volume not attached, Hence, resize is failing
>
>
> This addresses bug CLOUDSTACK-1995.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_volumes.py 36eb5de
>
> Diff: https://reviews.apache.org/r/10393/diff/
>
>
> Testing
> -------
>
> Tested with KVM and XenServer hypervisors with local storage. I couldn't test on shared storage because of a bug related to primary storage
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: Enhance resize volume tests to support xenserver
hypervisor and fix few test flow errors
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10393/#review19057
-----------------------------------------------------------
test/integration/smoke/1
<https://reviews.apache.org/r/10393/#comment39607>
This file was probably added unintentionally. Can you remove it?
test/integration/smoke/test_volumes.py
<https://reviews.apache.org/r/10393/#comment39608>
Why would a sleep be required here? Can you add a comment for why?
test/integration/smoke/test_volumes.py
<https://reviews.apache.org/r/10393/#comment39609>
This sleep can also be removed since virtual_machine.stop returns only after the VM moves to stopped state.
test/integration/smoke/test_volumes.py
<https://reviews.apache.org/r/10393/#comment39610>
Same as above.
- Prasanna Santhanam
On April 12, 2013, 6:35 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10393/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:35 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen.
>
>
> Description
> -------
>
> Based on hypervisor, resizeVolume needs VM to be in stopped state for xenserver.
>
> Earlier tests had volume not attached, Hence, resize is failing
>
>
> This addresses bug CLOUDSTACK-1995.
>
>
> Diffs
> -----
>
> test/integration/smoke/1 PRE-CREATION
> test/integration/smoke/test_volumes.py 36eb5de
>
> Diff: https://reviews.apache.org/r/10393/diff/
>
>
> Testing
> -------
>
> Tested with KVM and XenServer hypervisors with local storage. I couldn't test on shared storage because of a bug related to primary storage
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: Enhance resize volume tests to support xenserver
hypervisor and fix few test flow errors
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10393/#review19177
-----------------------------------------------------------
Ship it!
commit 0abfe240c31e410e286169ac1f75aa564f267280
Author: Talluri <Sr...@citrix.com>
Date: Mon Apr 15 16:47:34 2013 +0530
CLOUDSTACK-1995: Enhance resize volume tests to support xenserver hypervisor and fix few test flow errors
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- Prasanna Santhanam
On April 15, 2013, 6:08 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10393/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 6:08 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen.
>
>
> Description
> -------
>
> Based on hypervisor, resizeVolume needs VM to be in stopped state for xenserver.
>
> Earlier tests had volume not attached, Hence, resize is failing
>
>
> This addresses bug CLOUDSTACK-1995.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_volumes.py 36eb5de
>
> Diff: https://reviews.apache.org/r/10393/diff/
>
>
> Testing
> -------
>
> Tested with KVM and XenServer hypervisors with local storage. I couldn't test on shared storage because of a bug related to primary storage
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: Enhance resize volume tests to support xenserver
hypervisor and fix few test flow errors
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10393/
-----------------------------------------------------------
(Updated April 15, 2013, 6:08 a.m.)
Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen.
Changes
-------
incorporated review comments and added cleanup part
Description
-------
Based on hypervisor, resizeVolume needs VM to be in stopped state for xenserver.
Earlier tests had volume not attached, Hence, resize is failing
This addresses bug CLOUDSTACK-1995.
Diffs (updated)
-----
test/integration/smoke/test_volumes.py 36eb5de
Diff: https://reviews.apache.org/r/10393/diff/
Testing
-------
Tested with KVM and XenServer hypervisors with local storage. I couldn't test on shared storage because of a bug related to primary storage
Thanks,
SrikanteswaraRao Talluri
Re: Review Request: Enhance resize volume tests to support xenserver
hypervisor and fix few test flow errors
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10393/
-----------------------------------------------------------
(Updated April 12, 2013, 6:35 a.m.)
Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen.
Description
-------
Based on hypervisor, resizeVolume needs VM to be in stopped state for xenserver.
Earlier tests had volume not attached, Hence, resize is failing
This addresses bug CLOUDSTACK-1995.
Diffs
-----
test/integration/smoke/1 PRE-CREATION
test/integration/smoke/test_volumes.py 36eb5de
Diff: https://reviews.apache.org/r/10393/diff/
Testing
-------
Tested with KVM and XenServer hypervisors with local storage. I couldn't test on shared storage because of a bug related to primary storage
Thanks,
SrikanteswaraRao Talluri